<div dir="ltr"><div>Adding <a class="GWVZpf gW" id="IloFPc-2" href="mailto:wildfly-dev@lists.jboss.org" tabindex="-1">+WildFly Dev</a> to the loop</div><div><br></div><div>Thanks for the explanation Rado.<br></div><div><br></div><div>TL;DR: A while ago Sanne pointed out that we do not set `node-identifier` in transaction subsystem by default. The default value for the `node-identifier` attribute it `1`. Not setting this attribute might cause problems in transaction recovery. Perhaps we could follow Rado's idea and set it to node name by default?</div><div><br></div><div>Some more comments inlined.</div><div><br></div><div>Thanks,</div><div>Sebastian</div><br><div class="gmail_quote"><div dir="ltr">On Fri, Apr 13, 2018 at 7:07 PM Radoslav Husar <<a href="mailto:rhusar@redhat.com">rhusar@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi Sebastian,<br>
<br>
On Wed, Apr 11, 2018 at 2:31 PM, Sebastian Laskawiec<br>
<<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>> wrote:<br>
> Hey Rado, Paul,<br>
><br>
> I started looking into this issue and it turned out that WF subsystem<br>
> template doesn't provide `node-identifier` attribute [1].<br>
<br>
I assume you mean that the default WildFly server profiles do not<br>
explicitly define the attribute. Right – thus the value defaults in<br>
the model to "1"<br>
<a href="https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L97" rel="noreferrer" target="_blank">https://github.com/wildfly/wildfly/blob/master/transactions/src/main/java/org/jboss/as/txn/subsystem/TransactionSubsystemRootResourceDefinition.java#L97</a><br>
which sole intention seems to be to log a warning on boot if the value<br>
is unchanged.<br>
Why they decided on a constant that will be inherently not unique as<br>
opposed to defaulting to the node name (which we already require to be<br>
unique) as clustering node name or undertow instance-id does, is<br>
unclear to me.<br>
Some context is on <a href="https://issues.jboss.org/browse/WFLY-1119" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/WFLY-1119</a>.<br></blockquote><div><br></div><div>In OpenShift environment we could set it to `hostname`. This is guaranteed to be unique in whole OpenShift cluster.</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
> I'm not sure if you guys are the right people to ask, but is it safe to<br>
> leave it set to default? Or shall I override our Infinispan templates and<br>
> add this parameter (as I mentioned before, in OpenShift this I wanted to set<br>
> it as Pod name trimmed to the last 23 chars since this is the limit).<br>
<br>
It is not safe to leave it set to "1" as that results in inconsistent<br>
processing of transaction recovery.<br>
IIUC we already set it to the node name for both EAP and JDG<br>
<a href="https://github.com/jboss-openshift/cct_module/blob/master/os-eap70-openshift/added/standalone-openshift.xml#L411" rel="noreferrer" target="_blank">https://github.com/jboss-openshift/cct_module/blob/master/os-eap70-openshift/added/standalone-openshift.xml#L411</a><br>
<a href="https://github.com/jboss-openshift/cct_module/blob/master/os-jdg7-conffiles/added/clustered-openshift.xml#L282" rel="noreferrer" target="_blank">https://github.com/jboss-openshift/cct_module/blob/master/os-jdg7-conffiles/added/clustered-openshift.xml#L282</a><br>
which in turn defaults to the pod name – so which profiles are we<br>
talking about here?<br></blockquote><div><br></div><div>Granted, we set it by default in CCT Modules. However in Infinispan we just grab provided transaction subsystem when rendering full configuration from featurepacks:</div><div><a href="https://github.com/infinispan/infinispan/blob/master/server/integration/feature-pack/src/main/resources/configuration/standalone/subsystems-cloud.xml#L19">https://github.com/infinispan/infinispan/blob/master/server/integration/feature-pack/src/main/resources/configuration/standalone/subsystems-cloud.xml#L19</a><br></div><div><br></div><div>The default configuration XML doesn't contain the `node-identifier` attribute. I can add it manually in the cloud.xml but I believe the right approach is to modify the transaction subsystem.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Rado<br>
<br>
> Thanks,<br>
> Seb<br>
><br>
> [1] usually set to node-identifier="${<a href="http://jboss.node.name" rel="noreferrer" target="_blank">jboss.node.name</a>}"<br>
><br>
><br>
> On Mon, Apr 9, 2018 at 10:39 AM Sanne Grinovero <<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>><br>
> wrote:<br>
>><br>
>> On 9 April 2018 at 09:26, Sebastian Laskawiec <<a href="mailto:slaskawi@redhat.com" target="_blank">slaskawi@redhat.com</a>> wrote:<br>
>> > Thanks for looking into it Sanne. Of course, we should add it (it can be<br>
>> > set<br>
>> > to the same name as hostname since those are unique in Kubernetes).<br>
>> ><br>
>> > Created <a href="https://issues.jboss.org/browse/ISPN-9051" rel="noreferrer" target="_blank">https://issues.jboss.org/browse/ISPN-9051</a> for it.<br>
>> ><br>
>> > Thanks again!<br>
>> > Seb<br>
>><br>
>> Thanks Sebastian!<br>
>><br>
>> ><br>
>> > On Fri, Apr 6, 2018 at 8:53 PM Sanne Grinovero <<a href="mailto:sanne@infinispan.org" target="_blank">sanne@infinispan.org</a>><br>
>> > wrote:<br>
>> >><br>
>> >> Hi all,<br>
>> >><br>
>> >> I've started to use the Infinispan Openshift Template and was browsing<br>
>> >> through the errors and warnings this produces.<br>
>> >><br>
>> >> In particular I noticed "WFLYTX0013: Node identifier property is set<br>
>> >> to the default value. Please make sure it is unique." being produced<br>
>> >> by the transaction system.<br>
>> >><br>
>> >> The node id is usually not needed for developer's convenience and<br>
>> >> assuming there's a single node in "dev mode", yet clearly the<br>
>> >> Infinispan template is meant to work with multiple nodes running so<br>
>> >> this warning seems concerning.<br>
>> >><br>
>> >> I'm not sure what the impact is on the transaction manager so I asked<br>
>> >> on the Narayana forums; Tom pointed me to some thourough design<br>
>> >> documents and also suggested the EAP image does set the node<br>
>> >> identifier:<br>
>> >> - <a href="https://developer.jboss.org/message/981702#981702" rel="noreferrer" target="_blank">https://developer.jboss.org/message/981702#981702</a><br>
>> >><br>
>> >> WDYT? we probably want the Infinispan template to set this as well, or<br>
>> >> silence the warning?<br>
>> >><br>
>> >> Thanks,<br>
>> >> Sanne<br>
>> >> _______________________________________________<br>
>> >> infinispan-dev mailing list<br>
>> >> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
>> >> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
>> ><br>
>> ><br>
>> > _______________________________________________<br>
>> > infinispan-dev mailing list<br>
>> > <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
>> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
>> _______________________________________________<br>
>> infinispan-dev mailing list<br>
>> <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
</blockquote></div></div>