<div dir="ltr">I'd say log it wherever it's less costly.<div><br></div><div>Originally I wanted this while I was adding new protocol changes to the Node.js client and the server was hanging. This was due to not sending some bytes, which couldn't figure out from the logs. I ended up looking at what the Java client was doing and solved it. At this stage, Intrinsics would probably have been more interested.</div><div><br>Later on I had an issue with a command and there I was more interested in finding the value of the remaining parameters at a later stage. So I guess CacheRequestProcessor would maybe be a better location?</div><div><br>Cheers</div><div>Galder<br><div><div><br><div class="gmail_quote"><div dir="ltr">On Mon, Aug 20, 2018 at 3:10 PM Radim Vansa <<a href="mailto:rvansa@redhat.com">rvansa@redhat.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">(Routing back to -dev list)<br>
<br>
Yes. This could be logged in the most readable format in the operation <br>
itself, rather than just the bytes as this gets parsed. <br>
CacheRequestProcessor is probably the best place to do so.<br>
Or are you interested in seeing that as it comes from the wire? In that <br>
case I'd suggest the Intrinsics.<br>
<br>
Radim<br>
<br>
On 08/20/2018 02:43 PM, Galder Zamarreno wrote:<br>
> Header is just one part of the operation. Individual operation <br>
> parameters, like version in replaceWithVersion are not logged<br>
><br>
> On Tue, Aug 14, 2018 at 6:22 PM Radim Vansa <<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a> <br>
> <mailto:<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>>> wrote:<br>
><br>
> The header is logged [1] once it gets parsed, but you don't get a log<br>
> for each byte being read. You could add logs into Intrinsics [2]<br>
> if you<br>
> find that useful. You can also see the requests themselves in the<br>
> access<br>
> log.<br>
><br>
> Or do you have any particular points where you'd like to get<br>
> something<br>
> logged on the protocol side? We could add log for entering each state<br>
> (log the current path in the grammar tree), though I'd prefer to<br>
> activate that just in debug builds since it will increase the code<br>
> size<br>
> significantly.<br>
><br>
> Radim<br>
><br>
> [1]<br>
> <a href="https://github.com/infinispan/infinispan/blob/master/server/hotrod/src/main/resources/hotrod.gr#L67" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/blob/master/server/hotrod/src/main/resources/hotrod.gr#L67</a><br>
> [2]<br>
> <a href="https://github.com/infinispan/infinispan/blob/master/server/hotrod/src/main/java/org/infinispan/server/hotrod/Intrinsics.java" rel="noreferrer" target="_blank">https://github.com/infinispan/infinispan/blob/master/server/hotrod/src/main/java/org/infinispan/server/hotrod/Intrinsics.java</a><br>
><br>
> On 08/14/2018 05:05 PM, Galder Zamarreno wrote:<br>
> > Seems like we've lost all Hot Rod server decoder logging somehow?<br>
> ><br>
> > There's no trace or anything of any requests coming in :( 🤦♂️<br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > infinispan-dev mailing list<br>
> > <a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
> <mailto:<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a>><br>
> > <a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a><br>
><br>
><br>
> -- <br>
> Radim Vansa <<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a> <mailto:<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>>><br>
> JBoss Performance Team<br>
><br>
<br>
-- <br>
Radim Vansa <<a href="mailto:rvansa@redhat.com" target="_blank">rvansa@redhat.com</a>><br>
JBoss Performance Team<br>
<br>
_______________________________________________<br>
infinispan-dev mailing list<br>
<a href="mailto:infinispan-dev@lists.jboss.org" target="_blank">infinispan-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/infinispan-dev" rel="noreferrer" target="_blank">https://lists.jboss.org/mailman/listinfo/infinispan-dev</a></blockquote></div></div></div></div></div>