[jboss-as7-dev] ACTION REQUIRED: Replace hardcoded URLs and adresses with arquillian resources.

Brian Stansberry brian.stansberry at redhat.com
Thu Feb 9 13:22:40 EST 2012


On 2/9/12 11:50 AM, Ondřej Žižka wrote:
> Well, non-Arq tests know what server they communicate to, so they should
> use the same values.
>

What same values?

> For tests that need to access the server prior to deployment - depends
> on what kind of access would they need. Managememt? I may pass the IP
> and mgmt port to tests as an additional system property.
>

Management is the case I know of. For example, setting up a security 
domain or something that the deployment requires. System properties 
would be fine; that's how it was done in AS 3,4,5,6. I figure that's the 
answer to my "What same values?" question above.

>
> Ondra
>
>
>
> Brian Stansberry píše v Čt 09. 02. 2012 v 11:07 -0600:
>> On the JIRA, please document how to get the appropriate configuration
>> element from the test environment for situations where
>> @ArquillianResource won't work. For example, non-Arquillian tests, and
>> tests that need to access the server prior to deployment.
>>
>> On 2/9/12 10:42 AM, OndřejŽižka wrote:
>> >  Hi,
>> >
>> >
>> >  I'd like to ask everyone to fix"their"  tests regarding $SUBJ.
>> >  E.g. this is not acceptable:
>> >  ModelControllerClient client =
>> >  ModelControllerClient.Factory.create(InetAddress.getByName("127.0.0.1"),
>> >  9999, getCallbackHandler());
>> >  or
>> >  MBeanServerConnection mbeanServer = JMXConnectorFactory.connect(new
>> >  JMXServiceURL("service:jmx:remoting-jmx://127.0.0.1:9999")).getMBeanServerConnection();
>> >
>> >  Such like these MUST be rewritten to fetch the addresses and ports from
>> >  an injected @ArquillianResource.
>> >
>> >  Here's a tracking jira:https://issues.jboss.org/browse/AS7-3696
>> >  Empty so far. Next week, I'll start going through the tests looking for
>> >  such cases, and fixing them. Or, creating jiras and assigning them to
>> >  the test authors.
>> >  That's why I hope this call to action will relieve me from most of that
>> >  tedious work :)
>> >
>> >
>> >  Thanks for cooperation.
>> >  Ondra
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >
>> >  _______________________________________________
>> >  jboss-as7-dev mailing list
>> >  jboss-as7-dev at lists.jboss.org  <mailto:jboss-as7-dev at lists.jboss.org>
>> >  https://lists.jboss.org/mailman/listinfo/jboss-as7-dev
>>
>>
>


-- 
Brian Stansberry
Principal Software Engineer
JBoss by Red Hat


More information about the jboss-as7-dev mailing list