[jboss-as7-dev] order of import statements

Jeff Mesnil jmesnil at redhat.com
Wed Oct 10 02:51:33 EDT 2012


On 10/09/2012 09:53 PM, David M. Lloyd wrote:
> On 10/09/2012 11:55 AM, Jeff Mesnil wrote:
>> If we agree with this default order, I can add a checkstyle rule[1] for this.
>
> We tried this before but it didn't work out because checkstyle gets
> confused about imports which are only used in Javadoc, and because
> regardless of checkstyle rules everyone cannot agree on an order, and
> anyway changes to existing code should NEVER EVER EVER EVER include
> import "cleanups", "reorgs", or anything of the sort (no matter how bad
> you think it is) along with "real" changes because it just obscures what
> has changed and causes trouble.

I agree with you and my point was to avoid these cosmetic changes as much as possible.

Then the onus is on me to not rely on the IDE to build the package imports and check manually in case I added by error unwanted 
packages.


-- 
Jeff Mesnil
JBoss, a division of Red Hat
http://jmesnil.net/


More information about the jboss-as7-dev mailing list