Ike,<br><br> I actually looked at using the Apache library (instead of writing my own) when I started, but did not follow that path simply because of the potential licensing issues. However, if Jason agrees that it is okay to go down that path, I would love to replace the custom multipart parsing code with a more mature library. That being said, the multipart parsing currently relies on a library Jason wrote a while back to treat the incoming stream as multipart data. I can certainly try digging into this to see if I can pinpoint what is causing the OOM issue (if it is in the HTTP server code itself or in the multipart stream class).<br>
<br>Thanks,<br><br>--Jonathan<br><br><div class="gmail_quote">On Fri, Apr 15, 2011 at 7:50 AM, Heiko Braun <span dir="ltr"><<a href="mailto:hbraun@redhat.com">hbraun@redhat.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
<br>
<br>
I've run into a OOM issue when uploading content through the HTTP API again.<br>
(<a href="https://issues.jboss.org/browse/JBAS-9268" target="_blank">https://issues.jboss.org/browse/JBAS-9268</a>)<br>
<br>
<br>
I did take a look at the current implementation and propose that we change it in the following way:<br>
<br>
- read multipart contents from mime boundary<br>
- replace the custom multipart stream implementation with a mature one (leans on apache commons fileupload)<br>
<br>
I've got this changes tested and verified in a custom branch:<br>
<a href="https://github.com/heiko-braun/jboss-as/commits/out_of_memory" target="_blank">https://github.com/heiko-braun/jboss-as/commits/out_of_memory</a><br>
<br>
However before going ahead, I would like get some feedback from<br>
<br>
a) the original author (Jonathan Pearlin. Welcome onboard btw)<br>
b) Jason wrt the Apache License sources (See org.jboss.as.domain.http.server.multipart.asf.*)<br>
<br>
<br>
Regards, Ike<br>
<br>
<br>
<br>
<br>
_______________________________________________<br>
jboss-as7-dev mailing list<br>
<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br>
</blockquote></div><br>