<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: Arial; font-size: 12pt; color: #000000'><br><br><hr id="zwchr"><blockquote id="DWT21994" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Jason T. Greene" <jason.greene@redhat.com><br><b>To: </b>"Stuart Douglas" <stuart.w.douglas@gmail.com><br><b>Cc: </b>"JBoss AS7 Development" <jboss-as7-dev@lists.jboss.org><br><b>Sent: </b>Wednesday, August 24, 2011 3:20:12 PM<br><b>Subject: </b>Re: [jboss-as7-dev] Moving EJB3 code into the AS7 source tree<br><br>On 8/24/11 4:08 PM, Stuart Douglas wrote:<br>> Hi Guys,<br>><br>> While looking at some EJB3 stuff I began to wonder just how much stuff<br>> from the JBoss EJB3 maven artefacts we actually use. Even though there<br>> is a lot of artefacts, it turns out that we use around 75 classes from<br>> EJB3, and more than half of them are timer service related (It looks<br>> like a lot of the stuff in the EJB3 package is either legacy stuff that<br>> is just hanging around).<br>><br>> Given that the majority of the actual EJB logic / implementation is in<br>> the AS modules (in the EJB and EE modules), I was wondering if it would<br>> be worth merging the whole of EJB into AS7 and dumping the EJB3<br>> aggregator project altogether.<br>><br>> I have a branch that does this here (although this branch has not<br>> migrated any tests yet):<br>><br>> https://github.com/stuartwdouglas/jboss-as/tree/remove<br>><br>> Personally I think this would make it much easier to refactor, and would<br>> also allow us to remove some adaptor classes between AS7 and EJB3 (e.g.<br>> AS7 has to sub class the EJB3 interceptors, rather than EJB3 providing<br>> real jboss invocation interceptors).<br><br>I agree 1000% on this. In the past we had already decided to keep the <br>ejb3 impl in the AS tree, so I think we should avoid splitting off <br>components that are purely ejb3 specific and don't have use elsewhere.<br><br>I haven't reviewed all of this patch, but one thing that I had noticed <br>earlier is that we have some code that was just copied over and not <br>really in use (e.g. some broken pool implementations). IMO if we aren't <br>using / supporting stuff in AS we should just not carry it over.<br></blockquote>+1 to both of these. It would make my life easier on the performance team too.<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><br>-- <br>Jason T. Greene<br>JBoss AS Lead / EAP Platform Architect<br>JBoss, a division of Red Hat<br>_______________________________________________<br>jboss-as7-dev mailing list<br>jboss-as7-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/jboss-as7-dev<br></blockquote><br></div></body></html>