<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div>I have updated by branch, I have migrated the tests and moved the ejb classes into org.jboss.as.ejb3. As far as I can see it is ready to merge if we decide to go ahead with this.</div><div><br></div><div>Stuart</div><div><br></div><br><div><div>On 25/08/2011, at 8:26 AM, Andrig Miller wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><div style="font-family: Arial; font-size: 12pt; color: rgb(0, 0, 0); "><br><br><hr id="zwchr"><blockquote id="DWT21994" style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt; "><b>From:<span class="Apple-converted-space"> </span></b>"Jason T. Greene" <<a href="mailto:jason.greene@redhat.com">jason.greene@redhat.com</a>><br><b>To:<span class="Apple-converted-space"> </span></b>"Stuart Douglas" <<a href="mailto:stuart.w.douglas@gmail.com">stuart.w.douglas@gmail.com</a>><br><b>Cc:<span class="Apple-converted-space"> </span></b>"JBoss AS7 Development" <<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a>><br><b>Sent:<span class="Apple-converted-space"> </span></b>Wednesday, August 24, 2011 3:20:12 PM<br><b>Subject:<span class="Apple-converted-space"> </span></b>Re: [jboss-as7-dev] Moving EJB3 code into the AS7 source tree<br><br>On 8/24/11 4:08 PM, Stuart Douglas wrote:<br>> Hi Guys,<br>><br>> While looking at some EJB3 stuff I began to wonder just how much stuff<br>> from the JBoss EJB3 maven artefacts we actually use. Even though there<br>> is a lot of artefacts, it turns out that we use around 75 classes from<br>> EJB3, and more than half of them are timer service related (It looks<br>> like a lot of the stuff in the EJB3 package is either legacy stuff that<br>> is just hanging around).<br>><br>> Given that the majority of the actual EJB logic / implementation is in<br>> the AS modules (in the EJB and EE modules), I was wondering if it would<br>> be worth merging the whole of EJB into AS7 and dumping the EJB3<br>> aggregator project altogether.<br>><br>> I have a branch that does this here (although this branch has not<br>> migrated any tests yet):<br>><br>> <a href="https://github.com/stuartwdouglas/jboss-as/tree/remove">https://github.com/stuartwdouglas/jboss-as/tree/remove</a><br>><br>> Personally I think this would make it much easier to refactor, and would<br>> also allow us to remove some adaptor classes between AS7 and EJB3 (e.g.<br>> AS7 has to sub class the EJB3 interceptors, rather than EJB3 providing<br>> real jboss invocation interceptors).<br><br>I agree 1000% on this. In the past we had already decided to keep the<span class="Apple-converted-space"> </span><br>ejb3 impl in the AS tree, so I think we should avoid splitting off<span class="Apple-converted-space"> </span><br>components that are purely ejb3 specific and don't have use elsewhere.<br><br>I haven't reviewed all of this patch, but one thing that I had noticed<span class="Apple-converted-space"> </span><br>earlier is that we have some code that was just copied over and not<span class="Apple-converted-space"> </span><br>really in use (e.g. some broken pool implementations). IMO if we aren't<span class="Apple-converted-space"> </span><br>using / supporting stuff in AS we should just not carry it over.<br></blockquote>+1 to both of these. It would make my life easier on the performance team too.<br><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt; "><br>--<span class="Apple-converted-space"> </span><br>Jason T. Greene<br>JBoss AS Lead / EAP Platform Architect<br>JBoss, a division of Red Hat<br>_______________________________________________<br>jboss-as7-dev mailing list<br><a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a></blockquote></div></div></span></blockquote></div><br></body></html>