<html><head><style type='text/css'>p { margin: 0; }</style></head><body><div style='font-family: Arial; font-size: 12pt; color: #000000'><br><br><hr id="zwchr"><blockquote id="DWT23576" style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><b>From: </b>"Remy Maucherat" <rmaucher@redhat.com><br><b>To: </b>jboss-as7-dev@lists.jboss.org<br><b>Sent: </b>Tuesday, October 18, 2011 11:31:04 AM<br><b>Subject: </b>Re: [jboss-as7-dev] Better handling of transaction leaks?<br><br>On Tue, 2011-10-18 at 21:28 +0530, Jaikiran Pai wrote:<br>> While looking into a test failure I noticed that currently user <br>> applications can end up leaking transactions (associated with the <br>> invocation thread):<br>> <br>> Servlet {<br>> <br>> doGet() {<br>> UserTransaction.begin();<br>> doSomeOp();<br>> fail();<br>> // no tx rollback/commit<br>> }<br>> }<br>> <br>> Subsequent transactions on that thread can lead to failures and other <br>> sorts of issues. Looking back at previous versions of AS, we had a valve <br>> http://anonsvn.jboss.org/repos/jbossas/trunk/tomcat/src/main/java/org/jboss/web/tomcat/service/jca/CachedConnectionValve.java <br>> which used to cleanup (and log an error) about the leaking transactions.<br>> <br>> Do we want something similar for AS7? Also, are there other "entry <br>> points" (like servlets for web requests) where such leaks can happen and <br>> needs to be taken care off?<br><br>JPA has automatic tracking of this sort of things using a valve (and<br>added only when needed).<br><br>For the insignificant amount of people that will do manual transactions<br>and can't be bothered to code properly, everyone gets to pay the cost of<br>transaction tracking for all requests to the web container, so I am<br>against this feature.<br></blockquote>+1000!<br><blockquote style="border-left: 2px solid rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica,Arial,sans-serif; font-size: 12pt;"><br>I remember being flamed pretty badly for daring disabling this "nice"<br>valve by default in AS 6 :) Hopefully it will go better this time.<br><br>-- <br>Remy Maucherat <rmaucher@redhat.com><br>Red Hat Inc<br><br>_______________________________________________<br>jboss-as7-dev mailing list<br>jboss-as7-dev@lists.jboss.org<br>https://lists.jboss.org/mailman/listinfo/jboss-as7-dev<br></blockquote><br></div></body></html>