<html><head><base href="x-msg://34/"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">I agree with everything Andy said and absolutely needed to be able to set maxThreads in our TorqueBox benchmarks. There may be some hypothetical reason I shouldn't need to set maxThreads but in practice the performance before and after was night and day once a hit a high enough concurrent client load. The defaults of 512 * # of CPUs was way too high - 4096 http threads on my 8 CPU benchmark server kills performance and eats up way too many resources.<div><br></div><div>Ben</div><div><br><div><div>On Oct 20, 2011, at 5:41 PM, Andrig Miller wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div><div style="font-family: Arial; font-size: 12pt; color: rgb(0, 0, 0); ">Well, right now based on my testing, if you use the JBoss Threads executor, then you get a performance degradation. It's not big, but its still there.<br><br>If you cannot set maxThreads, then I don't see how we can get the best possible performance on our benchmark efforts. As you increase the injection rate, and run on the large scale hardware we have planned, we will have to be able to set that.<br><br>So, I understand it can be abused, but so can a lot of settings. That's why we have the administration and performance tuning guides (which I will be updating for EAP 6).<br><br>Andy<br><br><hr id="zwchr"><blockquote style="border-left-width: 2px; border-left-style: solid; border-left-color: rgb(16, 16, 255); margin-left: 5px; padding-left: 5px; color: rgb(0, 0, 0); font-weight: normal; font-style: normal; text-decoration: none; font-family: Helvetica, Arial, sans-serif; font-size: 12pt; "><b>From:<span class="Apple-converted-space"> </span></b>"Jason T. Greene" <<a href="mailto:jason.greene@redhat.com">jason.greene@redhat.com</a>><br><b>To:<span class="Apple-converted-space"> </span></b>"Brian Stansberry" <<a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a>><br><b>Cc:<span class="Apple-converted-space"> </span></b>"Andrig Miller" <<a href="mailto:anmiller@redhat.com">anmiller@redhat.com</a>>,<span class="Apple-converted-space"> </span><a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br><b>Sent:<span class="Apple-converted-space"> </span></b>Thursday, October 20, 2011 3:27:58 PM<br><b>Subject:<span class="Apple-converted-space"> </span></b>Re: [jboss-as7-dev] Controlling Maximum Number of JBoss Web HTTP Threads<br><br>Remy has indicated in the past that he does not want to expose that<span class="Apple-converted-space"> </span><br>level of tuning in the default jbossweb pool because of common<span class="Apple-converted-space"> </span><br>misuse/misconception about the settings. (IIRC he was against maxthreads<span class="Apple-converted-space"> </span><br>for example)<br><br>On 10/20/11 4:16 PM, Brian Stansberry wrote:<br>> I don't know; I'd need the JBoss Web guys to answer that.<br>><br>> On 10/20/11 4:00 PM, Andrig Miller wrote:<br>>> Do the configuration elements align with the default executor in JBoss<br>>> Web, which is not the JBoss Threads implementation?<br>>><br>>> Andy<br>>><br>>> ------------------------------------------------------------------------<br>>><br>>> *From: *"Brian Stansberry"<<a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a>><br>>> *To:<span class="Apple-converted-space"> </span><a href="mailto:*jboss-as7-dev@lists.jboss.org">*jboss-as7-dev@lists.jboss.org</a><br>>> *Sent: *Thursday, October 20, 2011 1:24:41 PM<br>>> *Subject: *Re: [jboss-as7-dev] Controlling Maximum Number of JBoss<br>>> Web HTTP Threads<br>>><br>>> If the web subsystem config is going to change, I'd like to see if it<br>>> can be made to work the way JCA does[1] -- a config element aligned<br>>> with<br>>> the appropriate pool type in the jboss-as-threads.xsd.<br>>><br>>> [1]<br>>> <a href="https://github.com/jbossas/jboss-as/blob/master/build/src/main/resources/docs/schema/jboss-as-jca_1_0.xsd#L120">https://github.com/jbossas/jboss-as/blob/master/build/src/main/resources/docs/schema/jboss-as-jca_1_0.xsd#L120</a><br>>><br>>> On 10/20/11 2:17 PM, Andrig Miller wrote:<br>>> > Good thing you looked at the code. I assumed that it impacted the<br>>> > threads. I guess the defaults have always been big enough for all the<br>>> > tests I have done then. We should open a JIRA on JBoss Web to add the<br>>> > maxThreads attribute to the XML schema that goes into domain.xml and<br>>> > standalone.xml, and have it defined as read-write, so this can be<br>>> changed.<br>>> ><br>>> > Andy<br>>> ><br>>> ><br>>> ------------------------------------------------------------------------<br>>> ><br>>> > *From: *"Benjamin Browning"<<a href="mailto:bbrowning@redhat.com">bbrowning@redhat.com</a>><br>>> > *To: *"Andrig Miller"<<a href="mailto:anmiller@redhat.com">anmiller@redhat.com</a>><br>>> > *Cc: *"<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><span class="Apple-converted-space"> </span>Development"<br>>> > <<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a>><br>>> > *Sent: *Thursday, October 20, 2011 12:02:56 PM<br>>> > *Subject: *Re: Controlling Maximum Number of JBoss Web HTTP Threads<br>>> ><br>>> > The max-connections attribute has no impact on the maximum http<br>>> > threads. If you look at the code, all it does is set the maximum<br>>> > poller size and sendfile size for the underlying JIoEndpoint.<br>>> ><br>>> > To control the threads you either have to use an external executor<br>>> > or set the maxThreads attribute on the protocol handler (which in<br>>> > turn sets it on the underlying JIoEndpoint).<br>>> ><br>>> > Ben<br>>> ><br>>> > On Oct 20, 2011, at 1:47 PM, Andrig Miller wrote:<br>>> ><br>>> > Ben,<br>>> ><br>>> > I think all you have to do is set max-connections="n" to the<br>>> > number of threads you want. That's what I have been doing, and<br>>> > based on looking at the running threads through JConsole, it<br>>> > seems to work just fine. In terms of the executor attribute, and<br>>> > setting up a pool using JBoss Threads, I have done extensive<br>>> > testing. I usually see only a small degradation between the two,<br>>> > like around 1% or so.<br>>> ><br>>> > Of course, that may vary based on what executor you choose to<br>>> > use, but I was using the unbounded queue thread thread pool with<br>>> > good success. I also changed the keepalive time, to keep the<br>>> > threads around for at least an hour, so to avoid churn in my<br>>> > testing between executions.<br>>> ><br>>> > Andy<br>>> ><br>>> ><br>>> ------------------------------------------------------------------------<br>>> ><br>>> > *From:*"Benjamin Browning"<<a href="mailto:bbrowning@redhat.com">bbrowning@redhat.com</a><br>>> > <<a href="mailto:bbrowning@redhat.com">mailto:bbrowning@redhat.com</a>>><br>>> > *To:*"Andrig Miller"<<a href="mailto:anmiller@redhat.com">anmiller@redhat.com</a><br>>> > <<a href="mailto:anmiller@redhat.com">mailto:anmiller@redhat.com</a>>><br>>> > *Cc:*"<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>>> > <<a href="mailto:jboss-as7-dev@lists.jboss.org">mailto:jboss-as7-dev@lists.jboss.org</a>>Development"<br>>> > <<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>>> > <<a href="mailto:jboss-as7-dev@lists.jboss.org">mailto:jboss-as7-dev@lists.jboss.org</a>>><br>>> > *Sent:*Thursday, October 20, 2011 10:32:01 AM<br>>> > *Subject:*Controlling Maximum Number of JBoss Web HTTP Threads<br>>> ><br>>> > I split this thread off from "Two thread pools section in<br>>> > management API" since it's not directly related.<br>>> ><br>>> > In my testing I was never able to create an executor for<br>>> > JBoss Web that didn't have dismal performance. Since<br>>> > TorqueBox needs to be able to easily control the maximum<br>>> > number of http threads we've written a simple service that<br>>> > reads a system property and sets the http connector's<br>>> > protocol handler's maxThreads. This works great and doesn't<br>>> > incur the performance hit of using a separate executor. If<br>>> > there's interest, we could submit a patch upstream to accept<br>>> > a max-threads attribute on the connector definitions.<br>>> ><br>>> > Ben<br>>> ><br>>> > On Oct 20, 2011, at 12:15 PM, Andrig Miller wrote:<br>>> ><br>>> > One thing that I have found with playing around with the<br>>> > various subsystems, is JBoss Web. JBoss Web doesn't<br>>> > expose a thread pool configuration, just a single<br>>> > attribute called max-connections. It also then has an<br>>> > "executor" attribute, which just takes a thread pool<br>>> > name from the JBoss Threads configuration.<br>>> ><br>>> > So, this one is inconsistent with the other subsystems,<br>>> > and I'm not sure if it should be changed to be<br>>> > consistent or not, since the default doesn't use JBoss<br>>> > Threads. This would also complicate any "global" view in<br>>> > the console.<br>>> ><br>>> > Andy<br>>> ><br>>> ><br>>> ><br>>> ><br>>> ><br>>> ><br>>> ><br>>> ><br>>> > _______________________________________________<br>>> > jboss-as7-dev mailing list<br>>> > <a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>>> > <a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br>>><br>>><br>>> --<br>>> Brian Stansberry<br>>> Principal Software Engineer<br>>> JBoss by Red Hat<br>>> _______________________________________________<br>>> jboss-as7-dev mailing list<br>>> <a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>>> <a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br>>><br>>><br>><br>><br><br><br>--<span class="Apple-converted-space"> </span><br>Jason T. Greene<br>JBoss AS Lead / EAP Platform Architect<br>JBoss, a division of Red Hat<br></blockquote><br></div>_______________________________________________<br>jboss-as7-dev mailing list<br><a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br><a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br></div></span></blockquote></div><br></div></body></html>