<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.18.3">
</HEAD>
<BODY>
<BR>
<BLOCKQUOTE TYPE=CITE>
<PRE>
I guess I don't see what if anything in this pull we would want to keep
if we went to a small module approach?
Maybe you could explain that?
</PRE>
</BLOCKQUOTE>
<BR>
Sure, any time. I assume you haven't been following the testsuite discussions for a while, where people complain about this and that not working, so I will try to sum up the issues with the current master's testsuite.<BR>
<BR>
1) This pull IS the small module approach. The only thing remaining is to move the tests.<BR>
I think this single argument makes it a good candidate for merging.<BR>
<BR>
2) You may consider it "livable for a while", but you'll leave it once AS 7.1 is released. AS7 will get productized to EAP, and QA dept will use the testsuite for a decade. "livable for a while" is not the condition we may let it in.<BR>
3) Workdir moved. Running it in user.dir leaves files there.<BR>
4) Introduced properties which carry important directories to the tests.<BR>
5) Fixed tests which assumed running in testsuite/integration to use those properties.<BR>
6) Other properties necessary for product testing are propagated to the tests.<BR>
7) Tests grouping made possible. One of requirements was to run smoke tests by default... well, this is described below.<BR>
8) pom.xml's are cleaned up a bit by removing unnecessary classpath stuff which is needed in master's TS.<BR>
9) pom.xml's are cleaned up a bit by using maven's inheritance more.<BR>
10) Ant scripts use dir properties which makes them easier to maintain & move around, and use from various modules without passing additional arguments.<BR>
11) ./build.sh -DskipTests works.<BR>
12) Multiple surefire executions when -Dtest=... is set are supressed.<BR>
13) Created integration testsuite sub-modules and moved the executions there. <------- This part is the MORE SMALL MODULES btw.<BR>
<BR>
Probably I missed some things.<BR>
Anyway, this is the base for EAP's testsuite, i.e. for fulfilling QA dept's requirements. Current master's testsuite can't fullfill these requirements. I see no point in delaying merging this since there are not much possibilities how to satisfy those needs, this is the best I can come up with.<BR>
Once more - it's half way to "more small modules".<BR>
<BR>
<BR>
Regards,<BR>
Ondra
</BODY>
</HTML>