<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 TRANSITIONAL//EN">
<HTML>
<HEAD>
<META HTTP-EQUIV="Content-Type" CONTENT="text/html; CHARSET=UTF-8">
<META NAME="GENERATOR" CONTENT="GtkHTML/3.18.3">
</HEAD>
<BODY>
If you have the old PR opened and try to open a new PR on the same branch, an "Update Commit Range" dialog appears.<BR>
After updating, the new commits are added. See <A HREF="https://github.com/jbossas/jboss-as/pull/925">https://github.com/jbossas/jboss-as/pull/925</A> .<BR>
<BR>
Ondra<BR>
<BR>
<BR>
<BR>
<BR>
Kabir Khan píše v Po 19. 12. 2011 v 10:45 +0000:
<BLOCKQUOTE TYPE=CITE>
<PRE>
Github support got back to me, no promises to change this so far - just a request for clarification
On 16 Dec 2011, at 18:11, Kabir Khan wrote:
> Due to the length of the pull queue and the number of requests that sit there for a while with a "negative" review awaiting further action from the committer I have started closing those asking people to reopen them. The intention of this was to have less noise for whoever is reviewing next.
>
> However, we noticed this has some problems, the workflow is something like this:
>
> -PR is submitted on xxxxx:branch_A with CommitA
> -PR gets closed
> -xxxx updates branch_A with CommitB and CommitC
> -PR gets reopened
> =>CommitB and CommitC are **NOT** visible in the PR
> -xxxx updates branch_A with CommitD
> => CommitB, CommitC and CommitD are visible in the PR
>
> So it seems like the pull request only polls for new commits while it is open. Anything committed when it was closed is invisible, until something else is committed once reopened.
>
> I'm not sure what the best way to solve this is (unless we stop closing stuff), perhaps to never reopen but to create a new request with a link to the old one so the comments are visible?
>
>
> _______________________________________________
> jboss-as7-dev mailing list
> <A HREF="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</A>
> <A HREF="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</A>
_______________________________________________
jboss-as7-dev mailing list
<A HREF="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</A>
<A HREF="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</A>
</PRE>
</BLOCKQUOTE>
</BODY>
</HTML>