Thanks, I understand the issue now.<br><br>--Oleg<br><br><div class="gmail_quote">15 февраля 2012 г. 19:35 пользователь Brian Stansberry <span dir="ltr"><<a href="mailto:brian.stansberry@redhat.com">brian.stansberry@redhat.com</a>></span> написал:<br>
<blockquote class="gmail_quote" style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Comments in-line:<br>
<div class="im"><br>
On 2/15/12 10:03 AM, Jaikiran Pai wrote:<br>
> Oleg, sorry about the late response.<br>
><br>
> Currently in AS7 we have xml parsing happening within the AS7 code base<br>
> for the following xmls:<br>
><br>
> 1) The standalone*.xml/domain*.xml<br>
<br>
</div>These files (and host.xml) should be excluded from this effort. They<br>
have significantly different requirements, primarily related to the need<br>
to maintain and write back the unresolved value.<br>
<div class="im"><br>
> 2) The jboss-deployment-structure.xml<br>
> 3) The jboss-ejb-client.xml<br>
> 4) The jboss-pojo xml<br>
> 5) The jboss-service.xml<br>
><br>
> and probably a few others. Then we have parsers in other projects<br>
> outside of AS7 codebase which deal with (for example):<br>
><br>
> 1) The spec specified EE descriptors like ejb-jar.xml, web.xml,<br>
> application.xml<br>
> 2) JBoss specific (EE) deployment descriptors for the deployments like<br>
> jboss-web.xml, jboss-app.xml, jboss-ejb3.xml<br>
><br>
> These have their own set of parsers.<br>
><br>
> So obviously trying to _share_ the same system property replacement<br>
> logic utility class, between these projects isn't going to work out. And<br>
> since it's just going to be one since class which is going to parse and<br>
> replace the system property, I think we should just create it in the AS7<br>
> code base and let the parsers in the AS7 code base use that (whichever<br>
> parser wants it). The other projects (like jboss-metadata) can use their<br>
> own (actually we just added one sometime back to support system property<br>
> replacement for "distinct-name" element in the JBoss specific EE<br>
> descriptors).<br>
><br>
> By the way, the DMR project has a class which handles this property<br>
> replacement (in that project). You might want to borrow that relevant<br>
> code<br>
> <a href="https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ExpressionValue.java#L110" target="_blank">https://github.com/jbossas/jboss-dmr/blob/master/src/main/java/org/jboss/dmr/ExpressionValue.java#L110</a>.<br>
><br>
<br>
</div>In a commment on the JIRA I pointed out the old jboss-common-core<br>
parsing method. But Jaikiran is right to highlight the DMR method as a<br>
better choice. Scott Stark added logic to it for resolving against the<br>
VM environment variables (System.getenv()) and not just the system<br>
properties.<br>
<div class="im HOEnZb"><br>
> -Jaikiran<br>
><br>
> On Friday 10 February 2012 02:31 PM, Oleg Kulikov wrote:<br>
>> Hi Jaikiran,<br>
>><br>
>> Can you explain more details about your vision of the property<br>
>> replacement task. In general it is interested how deep it should be<br>
>> shared between different substems where xml descriptors are used.<br>
>> Should it be a common parsing utility with description which properies<br>
>> allow expressions or it may be just a simple utility method shared<br>
>> between parsing methods?<br>
>><br>
>> -- Oleg.<br>
>><br>
>><br>
>> _______________________________________________<br>
>> jboss-as7-dev mailing list<br>
>> <a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>
>> <a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br>
><br>
> _______________________________________________<br>
> jboss-as7-dev mailing list<br>
> <a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>
> <a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br>
<br>
<br>
</div><span class="HOEnZb"><font color="#888888">--<br>
Brian Stansberry<br>
Principal Software Engineer<br>
JBoss by Red Hat<br>
</font></span><div class="HOEnZb"><div class="h5">_______________________________________________<br>
jboss-as7-dev mailing list<br>
<a href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br>
<a href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev" target="_blank">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br>
</div></div></blockquote></div><br>