<html><head>
<meta content="text/html; charset=ISO-8859-1" http-equiv="Content-Type">
</head><body text="#000000" bgcolor="#FFFFFF">Either one of these is
fine with me, although I think the best thing to do would be to simply
change it to an attachment list. I don't think there will actually be
many double up services, and we can just remove the double up's before
we use the list.<br>
<br>
Stuart<br>
<br>
<blockquote style="border: 0px none;"
cite="mid:16C33F29-A3AB-4312-87FA-11F2D41CD700@redhat.com" type="cite">
<div style="margin:30px 25px 10px 25px;" class="__pbConvHr"><div
style="display:table;width:100%;border-top:1px solid
#EDEEF0;padding-top:5px"> <div
style="display:table-cell;vertical-align:middle;padding-right:6px;"><img
photoaddress="emartins@redhat.com" photoname="Eduardo Martins"
src="cid:part1.05010402.07020302@gmail.com" name="postbox-contact.jpg"
width="25px" height="25px"></div> <div
style="display:table-cell;white-space:nowrap;vertical-align:middle;width:100%">
<a moz-do-not-send="true" href="mailto:emartins@redhat.com"
style="color:#737F92
!important;padding-right:6px;font-weight:bold;text-decoration:none
!important;">Eduardo Martins</a></div> <div
style="display:table-cell;white-space:nowrap;vertical-align:middle;">
<font color="#9FA2A5"><span style="padding-left:6px">5 September 2012
1:34 AM</span></font></div></div></div>
<div style="color:#888888;margin-left:24px;margin-right:24px;"
__pbrmquotes="true" class="__pbConvBody"><meta content="text/html;
charset=ISO-8859-1" http-equiv="Content-Type"><div>This naming
processor, which sets up a DU attachment for a set of jndi binding
service dependencies (to be added later on the component start service
so JNDI bindings are up when the component needs), is currently bound to
INSTALL phase, and this is limiting the usage of such set. For instance
in <a moz-do-not-send="true"
href="https://issues.jboss.org/browse/AS7-5443">https://issues.jboss.org/browse/AS7-5443</a>
the naming processors who set up app and module context, which are
bound to POST_MODULE phase, need to setup java:app/AppName and
java:module/ModuleName, and these need to be also up when the component
needs (e.g. @PreDestroy).</div><div><br></div><div>I see two ways of
minimise such limitations:</div><div><br></div><div>a) This attachment
is a set, which needs concrete setup, we could change it to a list, and
take advantage of Attachable#addToAttachmentList(...), which inits the
attachment list on demand. AFAIK the change from set to list would not
be an issue, cause duplicated entries in this list would be MSC
filtered/ignored (anyway we could always
introduce Attachable#addToAttachmentSet(...)). In the case this has no
side effects, we could even move the remaining logic of the processor
to JndiNamingDependencyProcessor and remove it.</div><div><br></div><div>b)
Move the Processor to an earlier phase, to ensure the attachment set is
already setup.</div><div><br></div><div>Opinions?</div><br><div
apple-content-edited="true">
<span style="border-collapse: separate; border-spacing: 0px; "
class="Apple-style-span"><span style="border-collapse: separate; color:
rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant:
normal; font-weight: normal; letter-spacing: normal; line-height:
normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px;
text-transform: none; white-space: normal; widows: 2; word-spacing: 0px;
-webkit-border-horizontal-spacing: 0px;
-webkit-border-vertical-spacing: 0px;
-webkit-text-decorations-in-effect: none; -webkit-text-size-adjust:
auto; -webkit-text-stroke-width: 0px; font-size: medium; "
class="Apple-style-span"><div style="word-wrap: break-word;
-webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">-- E</div></span></span>
</div>
<br><div>_______________________________________________<br>jboss-as7-dev
mailing list<br><a class="moz-txt-link-abbreviated" href="mailto:jboss-as7-dev@lists.jboss.org">jboss-as7-dev@lists.jboss.org</a><br><a class="moz-txt-link-freetext" href="https://lists.jboss.org/mailman/listinfo/jboss-as7-dev">https://lists.jboss.org/mailman/listinfo/jboss-as7-dev</a><br></div></div>
</blockquote>
</body></html>