[jboss-cvs] JBossAS SVN: r57962 - projects/aop/trunk/aop/src/main/org/jboss/aop

[jboss-cvs-commits at lists.jboss.org]

Author: kabir.khan at jboss.com
Date: 2006-11-01 08:38:45 -0500 (Wed, 01 Nov 2006)
New Revision: 57962

Modified:
   projects/aop/trunk/aop/src/main/org/jboss/aop/Advisor.java
   projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java
Log:
Improve logging when creating interceptor chains

Modified: projects/aop/trunk/aop/src/main/org/jboss/aop/Advisor.java
===================================================================
--- projects/aop/trunk/aop/src/main/org/jboss/aop/Advisor.java	2006-11-01 11:47:50 UTC (rev 57961)
+++ projects/aop/trunk/aop/src/main/org/jboss/aop/Advisor.java	2006-11-01 13:38:45 UTC (rev 57962)
@@ -691,8 +691,7 @@
                   throw new RuntimeException(e);
                }
                */
-               System.err.println("method matched binding " + binding.getPointcut().getExpr() + " " + method.toString());
-
+               System.err.println("[debug] method matched binding: " + method.toString());
             }
             binding.addAdvisor(this);
             MethodMatchInfo info = newMethodInterceptors.getMatchInfo(keys[i]);
@@ -904,7 +903,7 @@
          Constructor constructor = constructors[i];
          if (binding.getPointcut().matchesExecution(this, constructor))
          {
-            if (AspectManager.verbose) System.err.println(constructor + " matched binding " + binding.getName() + " " + binding.getPointcut().getExpr());
+            if (AspectManager.verbose) System.err.println("[debug] constructor matched binding: " + constructor);
             adviceBindings.add(binding);
             binding.addAdvisor(this);
             ConstructorInfo info = (ConstructorInfo)newConstructorInfos.get(i);
@@ -923,7 +922,7 @@
             Constructor constructor = info.getConstructor();
             if (binding.getPointcut().matchesConstruction(this, constructor))
             {
-               if (AspectManager.verbose) System.err.println(constructor + " matched binding " + binding.getName() + " " + binding.getPointcut().getExpr());
+               if (AspectManager.verbose) System.err.println("[debug] construction matched binding: " + constructor);
                adviceBindings.add(binding);
                binding.addAdvisor(this);
                pointcutResolved(info, binding, new ConstructorJoinpoint(constructor));

Modified: projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java
===================================================================
--- projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java	2006-11-01 11:47:50 UTC (rev 57961)
+++ projects/aop/trunk/aop/src/main/org/jboss/aop/ClassAdvisor.java	2006-11-01 13:38:45 UTC (rev 57962)
@@ -431,7 +431,7 @@
          if ((!write && binding.getPointcut().matchesGet(this, field))
          || (write && binding.getPointcut().matchesSet(this, field)))
          {
-            if (AspectManager.verbose) System.err.println("field matched binding " + binding.getName());
+            if (AspectManager.verbose) System.err.println("[debug] field matched " + ((write) ? "write" : "read") + " binding: " + field);
             adviceBindings.add(binding);
             binding.addAdvisor(this);
             FieldInfo info = (FieldInfo)newFieldInfos.get(i);
@@ -590,6 +590,7 @@
 
    private void createInterceptorChains() throws Exception
    {
+      if (AspectManager.verbose) System.out.println("[debug] Creating chains for " + clazz + " " + ((clazz != null) ? clazz.getClassLoader() : null ));
       MethodInterceptors newMethodInfos = initializeMethodChain();
       ArrayList newFieldReadInfos = initializeFieldReadChain();
       ArrayList newFieldWriteInfos = initializeFieldWriteChain();
@@ -602,7 +603,7 @@
          while (it.hasNext())
          {
             AdviceBinding binding = (AdviceBinding) it.next();
-            if (AspectManager.verbose) System.out.println("iterate binding " + binding.getName() + " " + binding.getPointcut().getExpr());
+            if (AspectManager.verbose) System.out.println("[debug] iterate binding " + binding.getName() + " " + binding.getPointcut().getExpr());
             resolveMethodPointcut(newMethodInfos, binding);
             resolveFieldPointcut(newFieldReadInfos, binding, false);
             resolveFieldPointcut(newFieldWriteInfos, binding, true);