[jboss-cvs] JBoss Messaging SVN: r1397 - in trunk/src/main/org/jboss: jms/server/endpoint messaging/core/plugin/postoffice/cluster

[jboss-cvs-commits at lists.jboss.org]

Author: timfox
Date: 2006-09-29 07:34:42 -0400 (Fri, 29 Sep 2006)
New Revision: 1397

Modified:
   trunk/src/main/org/jboss/jms/server/endpoint/ServerConsumerEndpoint.java
   trunk/src/main/org/jboss/messaging/core/plugin/postoffice/cluster/DefaultClusteredPostOffice.java
Log:
A couple more logging changes



Modified: trunk/src/main/org/jboss/jms/server/endpoint/ServerConsumerEndpoint.java
===================================================================
--- trunk/src/main/org/jboss/jms/server/endpoint/ServerConsumerEndpoint.java	2006-09-29 10:25:41 UTC (rev 1396)
+++ trunk/src/main/org/jboss/jms/server/endpoint/ServerConsumerEndpoint.java	2006-09-29 11:34:42 UTC (rev 1397)
@@ -228,10 +228,9 @@
             // make also possible to cut out the performance overhead for systems that raise the
             // threshold to INFO or higher.
 
-            if (log.isDebugEnabled())
-            {
-               log.debug(this + " NOT started yet!");
-            }
+            //TODO - Why was this debug
+            //log.isDebugEnabled is too slow!! especially on the primary execution path
+            if (trace) { log.trace(this + " NOT started yet!"); }
 
             return null;
          }

Modified: trunk/src/main/org/jboss/messaging/core/plugin/postoffice/cluster/DefaultClusteredPostOffice.java
===================================================================
--- trunk/src/main/org/jboss/messaging/core/plugin/postoffice/cluster/DefaultClusteredPostOffice.java	2006-09-29 10:25:41 UTC (rev 1396)
+++ trunk/src/main/org/jboss/messaging/core/plugin/postoffice/cluster/DefaultClusteredPostOffice.java	2006-09-29 11:34:42 UTC (rev 1397)
@@ -287,7 +287,7 @@
       
       started = true;   
       
-      if (log.isTraceEnabled()) { log.trace("Started " + this + " with address " + currentAddress); }
+      if (trace) { log.trace("Started " + this + " with address " + currentAddress); }
    }
 
    public synchronized void stop() throws Exception
@@ -302,14 +302,14 @@
       
       started = false;
       
-      if (log.isTraceEnabled()) { log.trace("Stopped " + this); }
+      if (trace) { log.trace("Stopped " + this); }
    }  
    
    // PostOffice implementation ---------------------------------------        
 
    public Binding bindClusteredQueue(String condition, LocalClusteredQueue queue) throws Exception
    {           
-      if (log.isTraceEnabled())
+      if (trace)
       {
          log.trace(this.nodeId + " binding clustered queue: " + queue + " with condition: " + condition);
       }
@@ -332,7 +332,7 @@
    
    public Binding unbindClusteredQueue(String queueName) throws Throwable
    {
-      if (log.isTraceEnabled())
+      if (trace)
       {
          log.trace(this.nodeId + " unbind clustered queue: " + queueName);
       }
@@ -536,7 +536,7 @@
    {
       lock.writeLock().acquire();
       
-      if (log.isTraceEnabled())
+      if (trace)
       {
          log.trace(this.nodeId + " adding binding from node: " + nodeId + " queue: " + queueName + " with condition: " + condition);        
       }
@@ -582,7 +582,7 @@
    {
       lock.writeLock().acquire();
       
-      if (log.isTraceEnabled())
+      if (trace)
       {
          log.trace(this.nodeId + " removing binding from node: " + nodeId + " queue: " + queueName);        
       }