[jboss-cvs] jbosside/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/build ...

Robert Stryker rob.stryker at jboss.com
Wed Apr 18 21:20:13 EDT 2007


  User: rawb    
  Date: 07/04/18 21:20:13

  Modified:    core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/build  
                        ModelChangeListener.java ArchiveBuildDelegate.java
  Log:
  Changes limit the amount of writing that must be done per build / model change. Postponed until the end. 
  
  Revision  Changes    Path
  1.2       +3 -5      jbosside/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/build/ModelChangeListener.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: ModelChangeListener.java
  ===================================================================
  RCS file: /cvsroot/jboss/jbosside/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/build/ModelChangeListener.java,v
  retrieving revision 1.1
  retrieving revision 1.2
  diff -u -b -r1.1 -r1.2
  --- ModelChangeListener.java	18 Apr 2007 21:07:53 -0000	1.1
  +++ ModelChangeListener.java	19 Apr 2007 01:20:13 -0000	1.2
  @@ -105,10 +105,10 @@
   	private void nodeAdded(IArchiveNode added) {
   		if( added.getNodeType() == IArchiveNode.TYPE_ARCHIVE) {
   			// create the package
  -			ModelTruezipBridge.createContainer(added);
  +			ModelTruezipBridge.createFile(added);
   		} else if( added.getNodeType() == IArchiveNode.TYPE_ARCHIVE_FOLDER ) {
   			// create hte folder
  -			ModelTruezipBridge.createContainer(added);
  +			ModelTruezipBridge.createFile(added);
   		}
   		IArchiveFileSet[] filesets = ModelUtil.findAllDescendentFilesets(added);
   		for( int i = 0; i < filesets.length; i++ ) {
  @@ -130,9 +130,7 @@
   		}
   
   		IArchiveFileSet[] filesets = ModelUtil.findAllDescendentFilesets(removed);
  -		for( int i = 0; i < filesets.length; i++ ) {
  -			ModelTruezipBridge.fullFilesetRemove(filesets[i]);
  -		}
  +		ModelTruezipBridge.fullFilesetsRemove(filesets);
   		refreshLocal(removed);
   	}
   	
  
  
  
  1.3       +5 -3      jbosside/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/build/ArchiveBuildDelegate.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: ArchiveBuildDelegate.java
  ===================================================================
  RCS file: /cvsroot/jboss/jbosside/core/plugins/org.jboss.ide.eclipse.archives.core/src/main/org/jboss/ide/eclipse/archives/core/build/ArchiveBuildDelegate.java,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -b -r1.2 -r1.3
  --- ArchiveBuildDelegate.java	19 Apr 2007 00:14:18 -0000	1.2
  +++ ArchiveBuildDelegate.java	19 Apr 2007 01:20:13 -0000	1.3
  @@ -13,6 +13,7 @@
   import org.jboss.ide.eclipse.archives.core.model.internal.ArchivesModel;
   import org.jboss.ide.eclipse.archives.core.util.ModelTruezipBridge;
   import org.jboss.ide.eclipse.archives.core.util.ModelUtil;
  +import org.jboss.ide.eclipse.archives.core.util.TrueZipUtil;
   
   public class ArchiveBuildDelegate {
   	
  @@ -32,7 +33,7 @@
   	
   	public void fullArchiveBuild(IArchive pkg) {
   		ModelTruezipBridge.deleteArchive(pkg);
  -		ModelTruezipBridge.createContainer(pkg);
  +		ModelTruezipBridge.createFile(pkg);
   		IArchiveFileSet[] filesets = ModelUtil.findAllDescendentFilesets(pkg);
   		for( int i = 0; i < filesets.length; i++ ) {
   			fullFilesetBuild(filesets[i]);
  @@ -63,14 +64,15 @@
   		while(i.hasNext()) {
   			path = ((IResource)i.next()).getLocation();
   			matchingFilesets = ModelUtil.getMatchingFilesets(path);
  -			ModelTruezipBridge.copyFiles(matchingFilesets, new IPath[] { path });
  +			ModelTruezipBridge.copyFiles(matchingFilesets, new IPath[] { path }, false);
   		}
   		
   		i = removed.iterator();
   		while(i.hasNext()) {
   			path = ((IResource)i.next()).getLocation();
   			matchingFilesets = ModelUtil.getMatchingFilesets(path);
  -			ModelTruezipBridge.deleteFiles(matchingFilesets, new IPath[] { path });
  +			ModelTruezipBridge.deleteFiles(matchingFilesets, new IPath[] { path }, false);
   		}
  +		TrueZipUtil.sync();
   	}
   }
  
  
  



More information about the jboss-cvs-commits mailing list