[jboss-cvs] JBossAS SVN: r64555 - in branches/JBPAPP_4_2_0_GA_CP: testsuite/src/main/org/jboss/test/web/test and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: dimitris at jboss.org
Date: 2007-08-13 06:26:48 -0400 (Mon, 13 Aug 2007)
New Revision: 64555

Added:
   branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/RemoteClassloadingServiceUnitTestCase.java
Modified:
   branches/JBPAPP_4_2_0_GA_CP/server/src/main/org/jboss/web/WebServer.java
Log:
JBPAPP-245

Modified: branches/JBPAPP_4_2_0_GA_CP/server/src/main/org/jboss/web/WebServer.java
===================================================================
--- branches/JBPAPP_4_2_0_GA_CP/server/src/main/org/jboss/web/WebServer.java	2007-08-13 10:17:47 UTC (rev 64554)
+++ branches/JBPAPP_4_2_0_GA_CP/server/src/main/org/jboss/web/WebServer.java	2007-08-13 10:26:48 UTC (rev 64555)
@@ -446,9 +446,9 @@
          {
             try
             {
-               log.trace("HTTP code=404 " + e.getMessage());
+               log.trace("HTTP code=404, " + e.getMessage());
                // Write out error response
-               out.writeBytes("HTTP/1.0 400 " + e.getMessage() + "\r\n");
+               out.writeBytes("HTTP/1.0 404 Not Found\r\n");
                out.writeBytes("Content-Type: text/html\r\n\r\n");
                out.flush();
             }

Added: branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/RemoteClassloadingServiceUnitTestCase.java
===================================================================
--- branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/RemoteClassloadingServiceUnitTestCase.java	                        (rev 0)
+++ branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/RemoteClassloadingServiceUnitTestCase.java	2007-08-13 10:26:48 UTC (rev 64555)
@@ -0,0 +1,60 @@
+/*
+ * JBoss, Home of Professional Open Source.
+ * Copyright 2006, Red Hat Middleware LLC, and individual contributors
+ * as indicated by the @author tags. See the copyright.txt file in the
+ * distribution for a full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.test.web.test;
+
+import java.net.HttpURLConnection;
+import java.net.URL;
+
+import org.apache.commons.httpclient.HttpMethodBase;
+import org.jboss.test.JBossTestCase;
+import org.jboss.test.util.web.HttpUtils;
+
+/**
+ * Test the remote classloading facility of the WebServer listening
+ * on post 8083
+ * 
+ * @author Dimitris.Andreadis at jboss.org
+ * @version $Revision: $
+ */
+public class RemoteClassloadingServiceUnitTestCase extends JBossTestCase
+{
+   static final String baseURL = "http://" + System.getProperty("jbosstest.server.host", "localhost") + ":8083/";
+   
+   public RemoteClassloadingServiceUnitTestCase(String name)
+   {
+      super(name);
+   }
+
+   /**
+    * JBAS-4540, don't leak installation directory info
+    * through the classloading service.
+    */
+   public void testHttpRequestRevealInstallationDirectory() throws Exception
+   {
+      URL url = new URL(baseURL + "org.jboss.web.WebServer.class");
+      HttpMethodBase request = HttpUtils.accessURL(url, null, HttpURLConnection.HTTP_NOT_FOUND);
+      String statusText = request.getStatusText();
+      
+      if (statusText.indexOf(".jar") > 0)
+         fail("Status text reveals installation directory information: " + statusText);
+   }
+}
\ No newline at end of file