[jboss-cvs] JBossAS SVN: r64872 - branches/JBoss_4_0_5_GA_CP/jmx/src/main/org/jboss/mx/loading.

[jboss-cvs-commits at lists.jboss.org]

Author: scott.stark at jboss.org
Date: 2007-08-25 00:03:52 -0400 (Sat, 25 Aug 2007)
New Revision: 64872

Modified:
   branches/JBoss_4_0_5_GA_CP/jmx/src/main/org/jboss/mx/loading/UnifiedLoaderRepository3.java
Log:
ASPATCH-288, deal with invalid property values

Modified: branches/JBoss_4_0_5_GA_CP/jmx/src/main/org/jboss/mx/loading/UnifiedLoaderRepository3.java
===================================================================
--- branches/JBoss_4_0_5_GA_CP/jmx/src/main/org/jboss/mx/loading/UnifiedLoaderRepository3.java	2007-08-25 03:53:52 UTC (rev 64871)
+++ branches/JBoss_4_0_5_GA_CP/jmx/src/main/org/jboss/mx/loading/UnifiedLoaderRepository3.java	2007-08-25 04:03:52 UTC (rev 64872)
@@ -77,9 +77,9 @@
     * org.jboss.mx.loading.UnifiedLoaderRepository.notifyMode system
     * property.
     */
-   private static int LEGACY_MODE = 0;
-   private static int WEAK_REFERENCE_MODE = 1;
-   private static int NO_NOTIFICATION_MODE = 2;
+   private static final int LEGACY_MODE = 0;
+   private static final int WEAK_REFERENCE_MODE = 1;
+   private static final int NO_NOTIFICATION_MODE = 2;
    private static int NOTIFICATION_MODE = LEGACY_MODE;
 
    // Attributes ----------------------------------------------------
@@ -159,9 +159,21 @@
 
    static
    {
-      // JBAS-4593
+      // JBAS-4593 notification behavior
       String value = ClassToStringAction.getProperty("org.jboss.mx.loading.UnifiedLoaderRepository.notifyMode", "0");
       NOTIFICATION_MODE = Integer.valueOf(value).intValue();
+      switch(NOTIFICATION_MODE)
+      {
+         case LEGACY_MODE:
+         case WEAK_REFERENCE_MODE:
+         case NO_NOTIFICATION_MODE:
+         break;
+         default:
+            log.warn("Invalid org.jboss.mx.loading.UnifiedLoaderRepository.notifyMode("
+                  +value+"), defaulting to LEGACY_MODE");
+            NOTIFICATION_MODE = LEGACY_MODE;
+         break;
+      }
    }
 
    // Public --------------------------------------------------------