[jboss-cvs] JBossCache/src/org/jboss/cache/notifications ...

[Manik Surtani]

  User: msurtani
  Date: 07/01/10 13:02:51

  Modified:    src/org/jboss/cache/notifications  Notifier.java
  Log:
  Removed unnecessary sync
  
  Revision  Changes    Path
  1.18      +12 -14    JBossCache/src/org/jboss/cache/notifications/Notifier.java
  
  (In the diff below, changes in quantity of whitespace are not shown.)
  
  Index: Notifier.java
  ===================================================================
  RCS file: /cvsroot/jboss/JBossCache/src/org/jboss/cache/notifications/Notifier.java,v
  retrieving revision 1.17
  retrieving revision 1.18
  diff -u -b -r1.17 -r1.18
  --- Notifier.java	10 Jan 2007 11:32:48 -0000	1.17
  +++ Notifier.java	10 Jan 2007 18:02:51 -0000	1.18
  @@ -135,8 +135,6 @@
         return Collections.unmodifiableSet(listeners);
      }
   
  -   // TODO: MANIK: Revisit these sync statements on these methods.  Needed to make sure all notifications from OptimisticCreateIfNotExistsInterceptor are delivered properly, but a very bad idea since a user's Listener may cause the cache to hang.
  -
      /**
       * Notifies all registered listeners of a nodeCreated event.
       *
  @@ -144,7 +142,7 @@
       * @param pre
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeCreated(Fqn fqn, boolean pre, boolean sendImmediately)
  +   public void notifyNodeCreated(Fqn fqn, boolean pre, boolean sendImmediately)
      {
   
         boolean originLocal = cache.getInvocationContext().isOriginLocal();
  @@ -180,7 +178,7 @@
       * @param data
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeModified(Fqn fqn, boolean pre, CacheListener.ModificationType modificationType, Map<Object, Object> data, boolean sendImmediately)
  +   public void notifyNodeModified(Fqn fqn, boolean pre, CacheListener.ModificationType modificationType, Map<Object, Object> data, boolean sendImmediately)
      {
         boolean originLocal = cache.getInvocationContext().isOriginLocal();
         Map dataCopy = copy(data);
  @@ -215,7 +213,7 @@
       * @param data
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeRemoved(Fqn fqn, boolean pre, Map<Object, Object> data, boolean sendImmediately)
  +   public void notifyNodeRemoved(Fqn fqn, boolean pre, Map<Object, Object> data, boolean sendImmediately)
      {
         boolean originLocal = cache.getInvocationContext().isOriginLocal();
         Map dataCopy = copy(data);
  @@ -250,7 +248,7 @@
       * @param pre
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeVisited(Fqn fqn, boolean pre, boolean sendImmediately)
  +   public void notifyNodeVisited(Fqn fqn, boolean pre, boolean sendImmediately)
      {
         if (sendImmediately)
         {
  @@ -276,7 +274,7 @@
   
      }
   
  -   public synchronized void notifyNodeMoved(Fqn originalFqn, Fqn newFqn, boolean pre, boolean sendImmediately)
  +   public void notifyNodeMoved(Fqn originalFqn, Fqn newFqn, boolean pre, boolean sendImmediately)
      {
         boolean originLocal = cache.getInvocationContext().isOriginLocal();
         if (sendImmediately)
  @@ -310,7 +308,7 @@
       * @param pre
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeEvicted(Fqn fqn, boolean pre, boolean sendImmediately)
  +   public void notifyNodeEvicted(Fqn fqn, boolean pre, boolean sendImmediately)
      {
         boolean originLocal = cache.getInvocationContext().isOriginLocal();
         if (sendImmediately)
  @@ -344,7 +342,7 @@
       * @param data
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeLoaded(Fqn fqn, boolean pre, Map<Object, Object> data, boolean sendImmediately)
  +   public void notifyNodeLoaded(Fqn fqn, boolean pre, Map<Object, Object> data, boolean sendImmediately)
      {
         Map dataCopy = copy(data);
         if (sendImmediately)
  @@ -377,7 +375,7 @@
       * @param pre
       * @param sendImmediately
       */
  -   public synchronized void notifyNodeActivated(Fqn fqn, boolean pre, boolean sendImmediately)
  +   public void notifyNodeActivated(Fqn fqn, boolean pre, boolean sendImmediately)
      {
         if (sendImmediately)
         {
  @@ -409,7 +407,7 @@
       * @param pre
       * @param sendImmediately
       */
  -   public synchronized void notifyNodePassivated(Fqn fqn, boolean pre, boolean sendImmediately)
  +   public void notifyNodePassivated(Fqn fqn, boolean pre, boolean sendImmediately)
      {
         if (sendImmediately)
         {
  @@ -440,7 +438,7 @@
       * @param cache
       * @param sendImmediately
       */
  -   public synchronized void notifyCacheStarted(CacheSPI cache, boolean sendImmediately)
  +   public void notifyCacheStarted(CacheSPI cache, boolean sendImmediately)
      {
         if (sendImmediately)
         {
  @@ -471,7 +469,7 @@
       * @param cache
       * @param sendImmediately
       */
  -   public synchronized void notifyCacheStopped(CacheSPI cache, boolean sendImmediately)
  +   public void notifyCacheStopped(CacheSPI cache, boolean sendImmediately)
      {
         if (sendImmediately)
         {
  @@ -502,7 +500,7 @@
       * @param new_view
       * @param sendImmediately
       */
  -   public synchronized void notifyViewChange(View new_view, boolean sendImmediately)
  +   public void notifyViewChange(View new_view, boolean sendImmediately)
      {
         if (sendImmediately)
         {