[jboss-cvs] JBossAS SVN: r77396 - trunk/tomcat/src/main/org/jboss/web/tomcat/service/modcluster/load/metric/impl.

[jboss-cvs-commits at lists.jboss.org]

Author: pferraro
Date: 2008-08-24 23:56:45 -0400 (Sun, 24 Aug 2008)
New Revision: 77396

Modified:
   trunk/tomcat/src/main/org/jboss/web/tomcat/service/modcluster/load/metric/impl/ActiveSessionsLoadMetric.java
Log:
Inject attribute name in constructor rather than expose mutator/accessor.

Modified: trunk/tomcat/src/main/org/jboss/web/tomcat/service/modcluster/load/metric/impl/ActiveSessionsLoadMetric.java
===================================================================
--- trunk/tomcat/src/main/org/jboss/web/tomcat/service/modcluster/load/metric/impl/ActiveSessionsLoadMetric.java	2008-08-25 02:20:21 UTC (rev 77395)
+++ trunk/tomcat/src/main/org/jboss/web/tomcat/service/modcluster/load/metric/impl/ActiveSessionsLoadMetric.java	2008-08-25 03:56:45 UTC (rev 77396)
@@ -34,24 +34,22 @@
  */
 public class ActiveSessionsLoadMetric extends AbstractLoadMetric
 {
-   private volatile String attribute = "LocalActiveSessions";
+   private static final String DEFAULT_ATTRIBUTE = "LocalActiveSessions";
    
    private final SessionLoadMetricSource source;
+   private final String attribute;
    
    public ActiveSessionsLoadMetric(SessionLoadMetricSource source)
    {
-      this.source = source;
-      
-      source.add(this);
+      this(source, DEFAULT_ATTRIBUTE);
    }
    
-   public String getActiveSessionsAttribute()
+   public ActiveSessionsLoadMetric(SessionLoadMetricSource source, String attribute)
    {
-      return this.attribute;
-   }
-   
-   public void setActiveSessionsAttribute(String attribute)
-   {
+      this.source = source;
+      
+      source.add(this);
+      
       this.attribute = attribute;
    }