[jboss-cvs] JBossAS SVN: r77437 - trunk/tomcat/src/main/org/jboss/web/tomcat/service/session.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Mon Aug 25 11:08:31 EDT 2008


Author: bstansberry at jboss.com
Date: 2008-08-25 11:08:31 -0400 (Mon, 25 Aug 2008)
New Revision: 77437

Modified:
   trunk/tomcat/src/main/org/jboss/web/tomcat/service/session/SessionIDGenerator.java
Log:
Fix singleton race condition

Modified: trunk/tomcat/src/main/org/jboss/web/tomcat/service/session/SessionIDGenerator.java
===================================================================
--- trunk/tomcat/src/main/org/jboss/web/tomcat/service/session/SessionIDGenerator.java	2008-08-25 15:04:41 UTC (rev 77436)
+++ trunk/tomcat/src/main/org/jboss/web/tomcat/service/session/SessionIDGenerator.java	2008-08-25 15:08:31 UTC (rev 77437)
@@ -43,13 +43,12 @@
 
    protected MessageDigest digest = null;
    protected Random random = null;
-   protected static SessionIDGenerator s_;
+   protected static final SessionIDGenerator s_ = new SessionIDGenerator();
    
    protected String sessionIdAlphabet = "ABCDEFGHIJKLMNOPQRSTUVWXYZabcdefghijklmnopqrstuvwxyz0123456789+-_";
 
    public static SessionIDGenerator getInstance()
    {
-      if (s_ == null) s_ = new SessionIDGenerator();
       return s_;
    }
 




More information about the jboss-cvs-commits mailing list