[jboss-cvs] JBossAS SVN: r75833 - projects/ejb3/trunk/pool/src/test/java/org/jboss/ejb3/test/pool/strictmax.

[jboss-cvs-commits at lists.jboss.org]

Author: wolfc
Date: 2008-07-15 04:59:04 -0400 (Tue, 15 Jul 2008)
New Revision: 75833

Modified:
   projects/ejb3/trunk/pool/src/test/java/org/jboss/ejb3/test/pool/strictmax/StrictMaxUnitTestCase.java
Log:
A ++ on a volatile is not atomic

Modified: projects/ejb3/trunk/pool/src/test/java/org/jboss/ejb3/test/pool/strictmax/StrictMaxUnitTestCase.java
===================================================================
--- projects/ejb3/trunk/pool/src/test/java/org/jboss/ejb3/test/pool/strictmax/StrictMaxUnitTestCase.java	2008-07-15 08:41:55 UTC (rev 75832)
+++ projects/ejb3/trunk/pool/src/test/java/org/jboss/ejb3/test/pool/strictmax/StrictMaxUnitTestCase.java	2008-07-15 08:59:04 UTC (rev 75833)
@@ -26,6 +26,7 @@
 import java.util.concurrent.Executors;
 import java.util.concurrent.Future;
 import java.util.concurrent.TimeUnit;
+import java.util.concurrent.atomic.AtomicInteger;
 
 import junit.framework.TestCase;
 
@@ -43,7 +44,7 @@
  */
 public class StrictMaxUnitTestCase extends TestCase
 {
-   volatile int used = 0;
+   AtomicInteger used = new AtomicInteger(0);
    
    @Override
    protected void setUp() throws Exception
@@ -51,7 +52,7 @@
       super.setUp();
       
       MockBean.reset();
-      used = 0;
+      used = new AtomicInteger(0);
    }
    
    public void test1()
@@ -101,7 +102,7 @@
                
                bean = null;
                
-               used++;
+               used.incrementAndGet();
             }
             
             return null;
@@ -124,7 +125,7 @@
       
       pool.stop();
       
-      assertEquals(400, used);
+      assertEquals(400, used.intValue());
       assertEquals(10, MockBean.getPostConstructs());
       assertEquals(10, MockBean.getPreDestroys());
    }