[jboss-cvs] JBossAS SVN: r73485 - in projects/ejb3/trunk/proxy/src: main/java/org/jboss/ejb3/proxy/factory/session and 5 other directories.

jboss-cvs-commits at lists.jboss.org jboss-cvs-commits at lists.jboss.org
Mon May 19 00:36:43 EDT 2008


Author: ALRubinger
Date: 2008-05-19 00:36:43 -0400 (Mon, 19 May 2008)
New Revision: 73485

Added:
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessProxyInvocationHandler.java
Removed:
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessLocalProxyInvocationHandler.java
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessRemoteProxyInvocationHandler.java
Modified:
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/container/InvokableContext.java
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionLocalProxyFactory.java
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionRemoteProxyFactory.java
   projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/ProxyInvocationHandlerBase.java
   projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/common/StatelessContainer.java
   projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/session/unit/ProxySessionTestCase.java
Log:
[EJBTHREE-1345] InvocationHandler is now the same for local/remote.  If jboss-metadata is hacked to get default JNDI names in proper form, Unit Tests for Proxy now pass locally.

Modified: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/container/InvokableContext.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/container/InvokableContext.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/container/InvokableContext.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -37,6 +37,14 @@
 public interface InvokableContext<T extends ContainerMethodInvocation>
 {
    /**
+    * The name of the "invoke" method for use in reflection
+    */
+   String METHOD_NAME_INVOKE = "invoke";
+   
+   String[] METHOD_SIGNATURE_INVOKE = new String[]
+   {Object.class.getName(), SerializableMethod.class.getName(), Object[].class.getName()};
+   
+   /**
     * Invokes the method described by the specified serializable method
     * as called from the specified proxy, using the specified arguments
     * 
@@ -46,5 +54,5 @@
     * @throws Throwable A possible exception thrown by the invocation
     * @return
     */
-   Object invoke(Object proxy, SerializableMethod method, Object... args) throws Throwable;
+   Object invoke(Object proxy, SerializableMethod method, Object[] args) throws Throwable;
 }

Modified: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/SessionProxyFactoryBase.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -130,7 +130,7 @@
       {
          // Create a new Proxy instance, and return
          return this.getConstructorProxyHome().newInstance(
-               this.getInvocationHandlerConstructor().newInstance(this.getContainerName()));
+               this.getInvocationHandlerConstructor().newInstance(this.getContainerName(),null));
 
       }
       catch (Throwable t)

Modified: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionLocalProxyFactory.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionLocalProxyFactory.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionLocalProxyFactory.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -26,7 +26,7 @@
 
 import org.jboss.ejb3.proxy.factory.session.SessionProxyFactory;
 import org.jboss.ejb3.proxy.handler.session.SessionProxyInvocationHandler;
-import org.jboss.ejb3.proxy.handler.session.stateless.StatelessLocalProxyInvocationHandler;
+import org.jboss.ejb3.proxy.handler.session.stateless.StatelessProxyInvocationHandler;
 import org.jboss.logging.Logger;
 import org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData;
 
@@ -112,13 +112,13 @@
    {
       try
       {
-         return StatelessLocalProxyInvocationHandler.class.getConstructor(new Class[]
+         return StatelessProxyInvocationHandler.class.getConstructor(new Class[]
          {String.class, String.class});
       }
       catch (NoSuchMethodException e)
       {
          throw new RuntimeException("Could not find Constructor with one String argument for "
-               + StatelessLocalProxyInvocationHandler.class.getName(), e);
+               + StatelessProxyInvocationHandler.class.getName(), e);
       }
    }
 

Modified: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionRemoteProxyFactory.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionRemoteProxyFactory.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/factory/session/stateless/StatelessSessionRemoteProxyFactory.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -26,7 +26,7 @@
 
 import org.jboss.ejb3.proxy.factory.session.SessionProxyFactory;
 import org.jboss.ejb3.proxy.handler.session.SessionProxyInvocationHandler;
-import org.jboss.ejb3.proxy.handler.session.stateless.StatelessRemoteProxyInvocationHandler;
+import org.jboss.ejb3.proxy.handler.session.stateless.StatelessProxyInvocationHandler;
 import org.jboss.logging.Logger;
 import org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData;
 
@@ -112,13 +112,13 @@
    {
       try
       {
-         return StatelessRemoteProxyInvocationHandler.class.getConstructor(new Class[]
+         return StatelessProxyInvocationHandler.class.getConstructor(new Class[]
          {String.class, String.class});
       }
       catch (NoSuchMethodException e)
       {
          throw new RuntimeException("Could not find Constructor with one String argument for "
-               + StatelessRemoteProxyInvocationHandler.class.getName(), e);
+               + StatelessProxyInvocationHandler.class.getName(), e);
       }
    }
 

Modified: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/ProxyInvocationHandlerBase.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/ProxyInvocationHandlerBase.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/ProxyInvocationHandlerBase.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -128,17 +128,17 @@
       // equals
       if (invokedMethod.equals(ProxyInvocationHandlerBase.METHOD_EQUALS))
       {
-         return new Boolean(proxy.equals(args[0]));
+         return new Boolean(this.equals(args[0]));
       }
       // toString
       if (invokedMethod.equals(ProxyInvocationHandlerBase.METHOD_TO_STRING))
       {
-         return proxy.toString();
+         return this.toString();
       }
       // hashCode
       if (invokedMethod.equals(ProxyInvocationHandlerBase.METHOD_HASH_CODE))
       {
-         return new Integer(proxy.hashCode());
+         return new Integer(this.hashCode());
       }
 
       // If no eligible methods were invoked

Deleted: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessLocalProxyInvocationHandler.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessLocalProxyInvocationHandler.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessLocalProxyInvocationHandler.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -1,105 +0,0 @@
-/*
- * JBoss, Home of Professional Open Source.
- * Copyright 2008, Red Hat Middleware LLC, and individual contributors
- * as indicated by the @author tags. See the copyright.txt file in the
- * distribution for a full listing of individual contributors.
-  *
- * This is free software; you can redistribute it and/or modify it
- * under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation; either version 2.1 of
- * the License, or (at your option) any later version.
- *
- * This software is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this software; if not, write to the Free
- * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
- */
-package org.jboss.ejb3.proxy.handler.session.stateless;
-
-import java.lang.reflect.Method;
-
-import org.jboss.ejb3.proxy.handler.NotEligibleForDirectInvocationException;
-import org.jboss.ejb3.proxy.handler.session.SessionSpecProxyInvocationHandlerBase;
-import org.jboss.ejb3.proxy.lang.SerializableMethod;
-import org.jboss.logging.Logger;
-import org.jboss.util.NotImplementedException;
-
-/**
- * StatelessLocalProxyInvocationHandler
- * 
- * Implementation of a SLSB Local Proxy Invocation Handler 
- *
- * @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
- * @version $Revision: $
- */
-public class StatelessLocalProxyInvocationHandler extends SessionSpecProxyInvocationHandlerBase
-{
-
-   // ------------------------------------------------------------------------------||
-   // Class Members ----------------------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   private static final Logger log = Logger.getLogger(StatelessLocalProxyInvocationHandler.class);
-
-   // ------------------------------------------------------------------------------||
-   // Constructors -----------------------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   /**
-    * Constructor
-    * 
-    * @param containerName The name under which the target container is registered
-    * @param businessInterfaceType The possibly null businessInterfaceType
-    *   marking this invocation hander as specific to a given
-    *   EJB3 Business Interface
-    */
-   public StatelessLocalProxyInvocationHandler(String containerName, String businessInterfaceType)
-   {
-      super(containerName, businessInterfaceType);
-   }
-
-   // ------------------------------------------------------------------------------||
-   // Required Implementations -----------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   //TODO
-
-   // ------------------------------------------------------------------------------||
-   // TO BE IMPLEMENTED ------------------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   public Object invoke(Object proxy, Method method, Object[] args) throws Throwable
-   {
-      // Set the invoked method
-      this.setInvokedMethod(new SerializableMethod(method));
-
-      // Attempt to handle directly
-      try
-      {
-         return this.handleInvocationDirectly(proxy, args);
-      }
-      // Ignore this, we just couldn't handle here
-      catch (NotEligibleForDirectInvocationException nefdie)
-      {
-         log.debug(nefdie.getMessage());
-      }
-
-      //TODO
-      throw new NotImplementedException("ALR");
-
-   }
-
-   /* (non-Javadoc)
-    * @see org.jboss.ejb3.proxy.handler.ProxyInvocationHandler#getAsynchronousProxy(java.lang.Object)
-    */
-   public Object getAsynchronousProxy(Object proxy)
-   {
-      throw new NotImplementedException("ALR");
-   }
-
-}

Copied: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessProxyInvocationHandler.java (from rev 73473, projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessLocalProxyInvocationHandler.java)
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessProxyInvocationHandler.java	                        (rev 0)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessProxyInvocationHandler.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -0,0 +1,135 @@
+/*
+ * JBoss, Home of Professional Open Source.
+ * Copyright 2008, Red Hat Middleware LLC, and individual contributors
+ * as indicated by the @author tags. See the copyright.txt file in the
+ * distribution for a full listing of individual contributors.
+  *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.ejb3.proxy.handler.session.stateless;
+
+import java.lang.reflect.InvocationHandler;
+import java.lang.reflect.Method;
+import java.util.ArrayList;
+import java.util.List;
+
+import org.jboss.ejb3.common.string.StringUtils;
+import org.jboss.ejb3.proxy.container.InvokableContext;
+import org.jboss.ejb3.proxy.hack.Hack;
+import org.jboss.ejb3.proxy.handler.NotEligibleForDirectInvocationException;
+import org.jboss.ejb3.proxy.handler.session.SessionSpecProxyInvocationHandlerBase;
+import org.jboss.ejb3.proxy.lang.SerializableMethod;
+import org.jboss.kernel.spi.registry.KernelBus;
+import org.jboss.logging.Logger;
+import org.jboss.util.NotImplementedException;
+
+/**
+ * StatelessProxyInvocationHandler
+ * 
+ * Implementation of a SLSB Proxy Invocation Handler 
+ *
+ * @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
+ * @version $Revision: $
+ */
+public class StatelessProxyInvocationHandler extends SessionSpecProxyInvocationHandlerBase
+{
+
+   // ------------------------------------------------------------------------------||
+   // Class Members ----------------------------------------------------------------||
+   // ------------------------------------------------------------------------------||
+
+   private static final Logger log = Logger.getLogger(StatelessProxyInvocationHandler.class);
+
+   // ------------------------------------------------------------------------------||
+   // Constructors -----------------------------------------------------------------||
+   // ------------------------------------------------------------------------------||
+
+   /**
+    * Constructor
+    * 
+    * @param containerName The name under which the target container is registered
+    * @param businessInterfaceType The possibly null businessInterfaceType
+    *   marking this invocation hander as specific to a given
+    *   EJB3 Business Interface
+    */
+   public StatelessProxyInvocationHandler(String containerName, String businessInterfaceType)
+   {
+      super(containerName, businessInterfaceType);
+   }
+
+   // ------------------------------------------------------------------------------||
+   // Required Implementations -----------------------------------------------------||
+   // ------------------------------------------------------------------------------||
+
+   //TODO
+
+   // ------------------------------------------------------------------------------||
+   // TO BE IMPLEMENTED ------------------------------------------------------------||
+   // ------------------------------------------------------------------------------||
+
+   public Object invoke(Object proxy, Method method, Object[] args) throws Throwable
+   {
+      // Set the invoked method
+      SerializableMethod invokedMethod = new SerializableMethod(method);
+      this.setInvokedMethod(invokedMethod);
+
+      // Attempt to handle directly
+      try
+      {
+         return this.handleInvocationDirectly(proxy, args);
+      }
+      // Ignore this, we just couldn't handle here
+      catch (NotEligibleForDirectInvocationException nefdie)
+      {
+         log.debug("Couldn't handle invocation directly within Proxy " + InvocationHandler.class.getName() + ": "
+               + nefdie.getMessage());
+      }
+
+      // Obtain the correct container from MC
+      //TODO This won't fly for remote, MC would be on another Process
+      KernelBus bus = Hack.BOOTSTRAP.getKernel().getBus();
+
+      // Obtain container name
+      String containerName = StringUtils.adjustWhitespaceStringToNull(this.getContainerName());
+      assert containerName != null : "Container name for invocation must be specified";
+
+      // Assemble arguments for invocation
+      List<Object> invocationArguments = new ArrayList<Object>();
+      // Add proxy as argument
+      invocationArguments.add(proxy);
+      // Add invoked method as argument
+      invocationArguments.add(invokedMethod);
+      // Add rest of arguments
+      invocationArguments.add(args);
+
+      // Invoke
+      log.debug("Invoking on MC Bean with name \"" + this.getContainerName() + "\" method \""
+            + InvokableContext.METHOD_NAME_INVOKE + "\" with arguments : " + invocationArguments);
+      return bus.invoke(this.getContainerName(), InvokableContext.METHOD_NAME_INVOKE, invocationArguments
+            .toArray(new Object[]
+            {}), InvokableContext.METHOD_SIGNATURE_INVOKE);
+
+   }
+
+   /* (non-Javadoc)
+    * @see org.jboss.ejb3.proxy.handler.ProxyInvocationHandler#getAsynchronousProxy(java.lang.Object)
+    */
+   public Object getAsynchronousProxy(Object proxy)
+   {
+      throw new NotImplementedException("ALR");
+   }
+
+}

Deleted: projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessRemoteProxyInvocationHandler.java
===================================================================
--- projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessRemoteProxyInvocationHandler.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/main/java/org/jboss/ejb3/proxy/handler/session/stateless/StatelessRemoteProxyInvocationHandler.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -1,97 +0,0 @@
-/*
- * JBoss, Home of Professional Open Source.
- * Copyright 2008, Red Hat Middleware LLC, and individual contributors
- * as indicated by the @author tags. See the copyright.txt file in the
- * distribution for a full listing of individual contributors.
-  *
- * This is free software; you can redistribute it and/or modify it
- * under the terms of the GNU Lesser General Public License as
- * published by the Free Software Foundation; either version 2.1 of
- * the License, or (at your option) any later version.
- *
- * This software is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
- * Lesser General Public License for more details.
- *
- * You should have received a copy of the GNU Lesser General Public
- * License along with this software; if not, write to the Free
- * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
- * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
- */
-package org.jboss.ejb3.proxy.handler.session.stateless;
-
-import java.lang.reflect.Method;
-
-import org.jboss.ejb3.common.string.StringUtils;
-import org.jboss.ejb3.proxy.hack.Hack;
-import org.jboss.ejb3.proxy.handler.session.SessionSpecProxyInvocationHandlerBase;
-import org.jboss.ejb3.proxy.lang.SerializableMethod;
-import org.jboss.kernel.spi.registry.KernelBus;
-import org.jboss.util.NotImplementedException;
-
-/**
- * StatelessRemoteProxyInvocationHandler
- * 
- * Implementation of a SLSB Remote Proxy Invocation Handler 
- *
- * @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
- * @version $Revision: $
- */
-public class StatelessRemoteProxyInvocationHandler extends SessionSpecProxyInvocationHandlerBase
-{
-
-   // ------------------------------------------------------------------------------||
-   // Constructors -----------------------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   /**
-    * Constructor
-    * 
-    * @param containerName The name under which the target container is registered
-    * @param businessInterfaceType The possibly null businessInterfaceType
-    *   marking this invocation hander as specific to a given
-    *   EJB3 Business Interface
-    */
-   public StatelessRemoteProxyInvocationHandler(String containerName, String businessInterfaceType)
-   {
-      super(containerName, businessInterfaceType);
-   }
-
-   // ------------------------------------------------------------------------------||
-   // Required Implementations -----------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   //TODO
-
-   // ------------------------------------------------------------------------------||
-   // TO BE IMPLEMENTED ------------------------------------------------------------||
-   // ------------------------------------------------------------------------------||
-
-   public Object invoke(Object proxy, Method method, Object[] args) throws Throwable
-   {
-      // Set the invoked method
-      this.setInvokedMethod(new SerializableMethod(method));
-
-      // Obtain the correct container from MC
-      //TODO This won't fly for remote, MC would be on another Process
-      KernelBus bus = Hack.BOOTSTRAP.getKernel().getBus();
-
-      // Obtain container name
-      String containerName = StringUtils.adjustWhitespaceStringToNull(this.getContainerName());
-      assert containerName != null : "Container name for invocation must be specified";
-
-      // Inoke
-      return bus.invoke(this.getContainerName(), this.getInvokedMethod().getName(), args, new String[]
-      {});
-   }
-
-   /* (non-Javadoc)
-    * @see org.jboss.ejb3.proxy.handler.ProxyInvocationHandler#getAsynchronousProxy(java.lang.Object)
-    */
-   public Object getAsynchronousProxy(Object proxy)
-   {
-      throw new NotImplementedException("ALR");
-   }
-
-}

Modified: projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/common/StatelessContainer.java
===================================================================
--- projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/common/StatelessContainer.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/common/StatelessContainer.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -68,7 +68,7 @@
     * @throws Throwable A possible exception thrown by the invocation
     * @return
     */
-   public Object invoke(Object proxy, SerializableMethod method, Object... args) throws Throwable
+   public Object invoke(Object proxy, SerializableMethod method, Object[] args) throws Throwable
    {
       // Get the types from the arguments
       List<Class<?>> types = new ArrayList<Class<?>>();
@@ -113,9 +113,6 @@
    {
       log.info("Starting " + this);
 
-      // TODO: a lot
-      log.fatal("StatelessContainer.start doesn't really do what's really supposed to happen");
-
       // Carlo's original code
       //      InitialContext ctx = new InitialContext();
       //      //String jndiName = metaData.determineLocalJndiName();

Modified: projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/session/unit/ProxySessionTestCase.java
===================================================================
--- projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/session/unit/ProxySessionTestCase.java	2008-05-19 03:57:34 UTC (rev 73484)
+++ projects/ejb3/trunk/proxy/src/test/java/org/jboss/ejb3/test/proxy/session/unit/ProxySessionTestCase.java	2008-05-19 04:36:43 UTC (rev 73485)
@@ -181,7 +181,7 @@
    {
       InitialContext ctx = new InitialContext();
 
-      Object bean = ctx.lookup("MyStatelessBean/home");
+      Object bean = ctx.lookup("MyStatelessBean/remoteHome"); // "home" or "remoteHome"?
       assertTrue(bean instanceof MyStatelessRemoteHome);
    }
 }




More information about the jboss-cvs-commits mailing list