[jboss-cvs] JBossAS SVN: r79570 - in projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb: jboss and 1 other directory.
jboss-cvs-commits at lists.jboss.org
jboss-cvs-commits at lists.jboss.org
Thu Oct 16 03:44:36 EDT 2008
Author: ALRubinger
Date: 2008-10-16 03:44:36 -0400 (Thu, 16 Oct 2008)
New Revision: 79570
Added:
projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/JBossSessionBeanValidatorBase.java
Modified:
projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/RemoteBindingsWithNoRemoteBusinessInterfaceValidator.java
Log:
[JBMETA-118] Centralize logic for JBossSessionBeanMetaData Validators
Added: projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/JBossSessionBeanValidatorBase.java
===================================================================
--- projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/JBossSessionBeanValidatorBase.java (rev 0)
+++ projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/JBossSessionBeanValidatorBase.java 2008-10-16 07:44:36 UTC (rev 79570)
@@ -0,0 +1,94 @@
+/*
+ * JBoss, Home of Professional Open Source.
+ * Copyright 2008, Red Hat Middleware LLC, and individual contributors
+ * as indicated by the @author tags. See the copyright.txt file in the
+ * distribution for a full listing of individual contributors.
+ *
+ * This is free software; you can redistribute it and/or modify it
+ * under the terms of the GNU Lesser General Public License as
+ * published by the Free Software Foundation; either version 2.1 of
+ * the License, or (at your option) any later version.
+ *
+ * This software is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+ * Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public
+ * License along with this software; if not, write to the Free
+ * Software Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
+ * 02110-1301 USA, or see the FSF site: http://www.fsf.org.
+ */
+package org.jboss.metadata.validation.validator.ejb;
+
+import org.jboss.logging.Logger;
+import org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData;
+import org.jboss.metadata.ejb.jboss.JBossEnterpriseBeansMetaData;
+import org.jboss.metadata.ejb.jboss.JBossMetaData;
+import org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData;
+import org.jboss.metadata.validation.ValidationException;
+import org.jboss.metadata.validation.validator.Validator;
+
+/**
+ * JBossSessionBeanValidatorBase
+ *
+ * Provides common functions and contract to validate all
+ * Session beans within full metadata
+ *
+ * @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
+ * @version $Revision: $
+ */
+public abstract class JBossSessionBeanValidatorBase implements Validator
+{
+
+ // --------------------------------------------------------------------------------||
+ // Class Members ------------------------------------------------------------------||
+ // --------------------------------------------------------------------------------||
+
+ private static final Logger log = Logger.getLogger(JBossSessionBeanValidatorBase.class);
+
+ // --------------------------------------------------------------------------------||
+ // Required Implementations -------------------------------------------------------||
+ // --------------------------------------------------------------------------------||
+
+ /* (non-Javadoc)
+ * @see org.jboss.metadata.validation.validator.Validator#validate(org.jboss.metadata.ejb.jboss.JBossMetaData)
+ */
+ public void validate(JBossMetaData md) throws ValidationException
+ {
+ // Get all EJBs
+ JBossEnterpriseBeansMetaData beans = md.getEnterpriseBeans();
+
+ // For each EJB
+ for (JBossEnterpriseBeanMetaData bean : beans)
+ {
+
+ // Only applies to Session Beans
+ if (!bean.isSession())
+ {
+ return;
+ }
+
+ // Cast
+ JBossSessionBeanMetaData smd = (JBossSessionBeanMetaData) bean;
+
+ // Validate
+ log.debug("Performing validation on Session EJB: + " + smd.getName());
+ this.validate(smd);
+
+ }
+ }
+
+ // --------------------------------------------------------------------------------||
+ // Contracts ----------------------------------------------------------------------||
+ // --------------------------------------------------------------------------------||
+
+ /**
+ * Validate the specified Session bean's metadata
+ *
+ * @param smd
+ * @throws ValidationException
+ */
+ protected abstract void validate(JBossSessionBeanMetaData smd) throws ValidationException;
+
+}
Modified: projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/RemoteBindingsWithNoRemoteBusinessInterfaceValidator.java
===================================================================
--- projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/RemoteBindingsWithNoRemoteBusinessInterfaceValidator.java 2008-10-16 06:49:38 UTC (rev 79569)
+++ projects/metadata/trunk/src/main/java/org/jboss/metadata/validation/validator/ejb/jboss/RemoteBindingsWithNoRemoteBusinessInterfaceValidator.java 2008-10-16 07:44:36 UTC (rev 79570)
@@ -26,14 +26,11 @@
import org.jboss.ejb3.annotation.RemoteBinding;
import org.jboss.logging.Logger;
import org.jboss.metadata.common.spi.ErrorCodes;
-import org.jboss.metadata.ejb.jboss.JBossEnterpriseBeanMetaData;
-import org.jboss.metadata.ejb.jboss.JBossEnterpriseBeansMetaData;
-import org.jboss.metadata.ejb.jboss.JBossMetaData;
import org.jboss.metadata.ejb.jboss.JBossSessionBeanMetaData;
import org.jboss.metadata.ejb.jboss.RemoteBindingMetaData;
import org.jboss.metadata.ejb.spec.BusinessRemotesMetaData;
import org.jboss.metadata.validation.ValidationException;
-import org.jboss.metadata.validation.validator.Validator;
+import org.jboss.metadata.validation.validator.ejb.JBossSessionBeanValidatorBase;
/**
* RemoteBindingsWithNoRemoteBusinessInterfaceValidator
@@ -47,7 +44,7 @@
* @author <a href="mailto:andrew.rubinger at jboss.org">ALR</a>
* @version $Revision: $
*/
-public class RemoteBindingsWithNoRemoteBusinessInterfaceValidator implements Validator
+public class RemoteBindingsWithNoRemoteBusinessInterfaceValidator extends JBossSessionBeanValidatorBase
{
// --------------------------------------------------------------------------------||
// Class Members ------------------------------------------------------------------||
@@ -64,58 +61,44 @@
// Required Implementations -------------------------------------------------------||
// --------------------------------------------------------------------------------||
- /* (non-Javadoc)
- * @see org.jboss.metadata.validation.validator.Validator#validate(org.jboss.metadata.ejb.jboss.JBossMetaData)
+ /**
+ * Validate the specified Session bean's metadata
+ *
+ * @param smd
+ * @throws ValidationException
*/
- public void validate(JBossMetaData md) throws ValidationException
+ protected void validate(JBossSessionBeanMetaData smd) throws ValidationException
{
// Initialize
String errorCode = ErrorCodes.ERROR_CODE_JBMETA117;
- // Get all EJBs
- JBossEnterpriseBeansMetaData beans = md.getEnterpriseBeans();
+ /*
+ * JBMETA-117
+ *
+ * No @RemoteBindings are allowed if there are no business remote interfaces
+ */
- // For each EJB
- for (JBossEnterpriseBeanMetaData bean : beans)
- {
+ // Get all business remotes
+ BusinessRemotesMetaData businessRemotes = smd.getBusinessRemotes();
- // Only applies to Session Beans
- if (!bean.isSession())
- {
- return;
- }
+ // Get all @RemoteBindings
+ List<RemoteBindingMetaData> remoteBindings = smd.getRemoteBindings();
- // Cast
- JBossSessionBeanMetaData smd = (JBossSessionBeanMetaData) bean;
-
- /*
- * JBMETA-117
- *
- * No @RemoteBindings are allowed if there are no business remote interfaces
- */
-
- // Get all business remotes
- BusinessRemotesMetaData businessRemotes = smd.getBusinessRemotes();
-
- // Get all @RemoteBindings
- List<RemoteBindingMetaData> remoteBindings = smd.getRemoteBindings();
-
- // If there are @RemoteBindings
- if (remoteBindings != null && remoteBindings.size() > 0)
+ // If there are @RemoteBindings
+ if (remoteBindings != null && remoteBindings.size() > 0)
+ {
+ // If there aren't any business remote interfaces
+ if (businessRemotes == null || businessRemotes.size() == 0)
{
- // If there aren't any business remote interfaces
- if (businessRemotes == null || businessRemotes.size() == 0)
- {
- // Fail
- throw new ValidationException("An @" + RemoteBinding.class.getSimpleName() + " was defined on EJB "
- + smd.getName() + ", but this bean has no remote business interfaces defined. [" + errorCode + "]");
- }
+ // Fail
+ throw new ValidationException("An @" + RemoteBinding.class.getSimpleName() + " was defined on EJB "
+ + smd.getName() + ", but this bean has no remote business interfaces defined. [" + errorCode + "]");
}
-
- // Log OK
- log.trace("Passed validation for " + errorCode);
}
+ // Log OK
+ log.trace("Passed validation for " + errorCode);
+
}
}
More information about the jboss-cvs-commits
mailing list