[jboss-cvs] JBoss Messaging SVN: r7749 - trunk/src/main/org/jboss/messaging/jms/client.

[jboss-cvs-commits at lists.jboss.org]

Author: jmesnil
Date: 2009-08-17 08:08:10 -0400 (Mon, 17 Aug 2009)
New Revision: 7749

Modified:
   trunk/src/main/org/jboss/messaging/jms/client/JBossConnectionFactory.java
Log:
JBMESSAGING-1714: Creating JMS connection with invalid user credentials leaves resources on the client

* close the connection if an exception is thrown by connection.authorize()

Modified: trunk/src/main/org/jboss/messaging/jms/client/JBossConnectionFactory.java
===================================================================
--- trunk/src/main/org/jboss/messaging/jms/client/JBossConnectionFactory.java	2009-08-17 11:29:59 UTC (rev 7748)
+++ trunk/src/main/org/jboss/messaging/jms/client/JBossConnectionFactory.java	2009-08-17 12:08:10 UTC (rev 7749)
@@ -532,7 +532,21 @@
                                                        transactionBatchSize,
                                                        sessionFactory);
 
-      connection.authorize();
+      
+      try {
+         connection.authorize();
+      } 
+      catch (JMSException e)
+      {
+         try
+         {
+            connection.close();
+         }
+         catch (JMSException me)
+         {
+         }
+         throw e;
+      }
 
       return connection;
    }