[jboss-cvs] JBossAS SVN: r90743 - projects/jboss-deployers/trunk/deployers-vfs-spi/src/main/java/org/jboss/deployers/vfs/spi/deployer.

[jboss-cvs-commits at lists.jboss.org]

Author: alesj
Date: 2009-07-01 08:13:05 -0400 (Wed, 01 Jul 2009)
New Revision: 90743

Modified:
   projects/jboss-deployers/trunk/deployers-vfs-spi/src/main/java/org/jboss/deployers/vfs/spi/deployer/JBossXBDeployer.java
Log:
[JBDEPLOY-202]; create helper in ctor to avoid any concurrency issues.

Modified: projects/jboss-deployers/trunk/deployers-vfs-spi/src/main/java/org/jboss/deployers/vfs/spi/deployer/JBossXBDeployer.java
===================================================================
--- projects/jboss-deployers/trunk/deployers-vfs-spi/src/main/java/org/jboss/deployers/vfs/spi/deployer/JBossXBDeployer.java	2009-07-01 10:51:48 UTC (rev 90742)
+++ projects/jboss-deployers/trunk/deployers-vfs-spi/src/main/java/org/jboss/deployers/vfs/spi/deployer/JBossXBDeployer.java	2009-07-01 12:13:05 UTC (rev 90743)
@@ -35,7 +35,7 @@
 public abstract class JBossXBDeployer<T> extends UnmarshallerFactoryDeployer<T, Boolean>
 {
    /** The helper */
-   private JBossXBHelper<T> helper;
+   private final JBossXBHelper<T> helper;
 
    /**
     * Create a new SchemaResolverDeployer.
@@ -46,18 +46,26 @@
    public JBossXBDeployer(Class<T> output)
    {
       super(output);
+      helper = createHelper();
    }
 
    /**
+    * Create the helper.
+    *
+    * @return new helper instance
+    */
+   protected JBossXBHelper<T> createHelper()
+   {
+      return new JBossXBHelper<T>(getOutput());
+   }
+
+   /**
     * Get the helper.
     *
     * @return the helper
     */
    protected JBossXBHelper<T> getHelper()
    {
-      if (helper == null)
-         helper = new JBossXBHelper<T>(getOutput());
-      
       return helper;
    }