[jboss-cvs] JBossAS SVN: r91865 - projects/bootstrap/trunk/impl-as/src/main/java/org/jboss/bootstrap/impl/as/server.

[jboss-cvs-commits at lists.jboss.org]

Author: ALRubinger
Date: 2009-07-31 00:41:55 -0400 (Fri, 31 Jul 2009)
New Revision: 91865

Modified:
   projects/bootstrap/trunk/impl-as/src/main/java/org/jboss/bootstrap/impl/as/server/AbstractJBossASServerBase.java
Log:
[JBBOOT-104] Do not export the mutable view of the config metadata

Modified: projects/bootstrap/trunk/impl-as/src/main/java/org/jboss/bootstrap/impl/as/server/AbstractJBossASServerBase.java
===================================================================
--- projects/bootstrap/trunk/impl-as/src/main/java/org/jboss/bootstrap/impl/as/server/AbstractJBossASServerBase.java	2009-07-31 04:35:30 UTC (rev 91864)
+++ projects/bootstrap/trunk/impl-as/src/main/java/org/jboss/bootstrap/impl/as/server/AbstractJBossASServerBase.java	2009-07-31 04:41:55 UTC (rev 91865)
@@ -24,6 +24,7 @@
 
 import java.io.File;
 import java.net.URL;
+import java.util.Collections;
 import java.util.Date;
 import java.util.Map;
 import java.util.concurrent.ConcurrentHashMap;
@@ -110,7 +111,7 @@
 
    /** 
     * The optional configuration metadata for the server.  No sync required as the backing
-    * instance is final.  Requires Thread-safe impl (as it's exported). 
+    * instance is final.  The mutable state must not be exported.
     */
    private final Map<String, Object> metadata = new ConcurrentHashMap<String, Object>();
 
@@ -239,12 +240,13 @@
       return version.getVersionNumber();
    }
 
-   /* (non-Javadoc)
-    * @see org.jboss.bootstrap.spi.server.Server#getMetaData()
+   /*
+    * (non-Javadoc)
+    * @see org.jboss.bootstrap.spi.as.server.JBossASBasedServerProvider#getMetaData()
     */
    public Map<String, Object> getMetaData()
    {
-      return this.metadata;
+      return Collections.unmodifiableMap(this.metadata);
    }
 
    /* (non-Javadoc)