[jboss-cvs] JBossAS SVN: r94089 - in branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web: test and 1 other directory.

[jboss-cvs-commits at lists.jboss.org]

Author: mmalina at redhat.com
Date: 2009-09-29 05:24:21 -0400 (Tue, 29 Sep 2009)
New Revision: 94089

Modified:
   branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/servlets/CookieServlet.java
   branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/CookieUnitTestCase.java
Log:
JBPAPP-2041 Removed the test for commented cookie in org.jboss.test.web.test.CookieUnitTestCase.testCookieRetrievedCorrectly

Modified: branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/servlets/CookieServlet.java
===================================================================
--- branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/servlets/CookieServlet.java	2009-09-29 07:01:38 UTC (rev 94088)
+++ branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/servlets/CookieServlet.java	2009-09-29 09:24:21 UTC (rev 94089)
@@ -44,11 +44,6 @@
 		cookie = new Cookie("withSpace", "jboss rocks");
 		response.addCookie(cookie);
 		
-		//cookie with comment
-		cookie = new Cookie("commented", "commented cookie");
-		cookie.setComment("This is a comment");
-		response.addCookie(cookie);
-		
 		//cookie with expiry time. This cookie must not be set on client side
 		cookie = new Cookie("expired","expired cookie");
 		cookie.setMaxAge(0);

Modified: branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/CookieUnitTestCase.java
===================================================================
--- branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/CookieUnitTestCase.java	2009-09-29 07:01:38 UTC (rev 94088)
+++ branches/JBPAPP_4_2_0_GA_CP/testsuite/src/main/org/jboss/test/web/test/CookieUnitTestCase.java	2009-09-29 09:24:21 UTC (rev 94089)
@@ -22,7 +22,7 @@
 public class CookieUnitTestCase extends JBossTestCase 
 
 {
-	protected static String[] cookieNames= {"simpleCookie","withSpace","commented","expired"}; 
+	protected static String[] cookieNames= {"simpleCookie","withSpace","expired"}; 
 	private String baseURL = HttpUtils.getBaseURL(); 
 	
 	public CookieUnitTestCase(String name) 
@@ -68,14 +68,7 @@
 			}
 			else if(cookies[i].getName().equals("withSpace"))	    		  
 				assertEquals("should be no quote in cookie with space", cookies[i].getValue().indexOf("\""),-1);
-			else if(cookies[i].getName().equals("commented"))	{	    		  
-				log.info("comment in cookie: " +  cookies[i].getComment());
-				//RFC2109:Note that there is no Comment attribute in the Cookie request header
-				//corresponding to the one in the Set-Cookie response header.  The user
-				//agent does not return the comment information to the origin server.
-				
-				assertTrue(cookies[i].getComment() == null);
-			}	else if(cookies[i].getName().equals("withComma")) {
+			else if(cookies[i].getName().equals("withComma")) {
 				assertTrue("should contain a comma", cookies[i].getValue().indexOf(",") != -1);
 			}
 			else if(cookies[i].getName().equals("expireIn10Sec"))	{