[jboss-cvs] JBossAS SVN: r107630 - in projects/jboss-jca/trunk: common/src/main/java/org/jboss/jca/common/metadata/ra/common and 2 other directories.

[jboss-cvs-commits at lists.jboss.org]

Author: maeste
Date: 2010-08-16 05:11:11 -0400 (Mon, 16 Aug 2010)
New Revision: 107630

Modified:
   projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/api/metadata/ra/ConnectionDefinition.java
   projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/ConnectionDefinitionImpl.java
   projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/OutboundResourceAdapterImpl.java
   projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java
   projects/jboss-jca/trunk/validator/src/main/java/org/jboss/jca/validator/Validation.java
Log:
removed all findbugs potential bug for common module

Modified: projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/api/metadata/ra/ConnectionDefinition.java
===================================================================
--- projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/api/metadata/ra/ConnectionDefinition.java	2010-08-16 09:09:33 UTC (rev 107629)
+++ projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/api/metadata/ra/ConnectionDefinition.java	2010-08-16 09:11:11 UTC (rev 107630)
@@ -45,7 +45,7 @@
    /**
     * @return managedconnectionfactoryClass
     */
-   public abstract XsdString getManagedconnectionfactoryClass();
+   public abstract XsdString getManagedConnectionFactoryClass();
 
    /**
     * @return configProperty
@@ -55,12 +55,12 @@
    /**
     * @return connectionfactoryInterface
     */
-   public abstract XsdString getConnectionfactoryInterface();
+   public abstract XsdString getConnectionFactoryInterface();
 
    /**
     * @return connectionfactoryImplClass
     */
-   public abstract XsdString getConnectionfactoryImplClass();
+   public abstract XsdString getConnectionFactoryImplClass();
 
    /**
     * @return connectionInterface

Modified: projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/ConnectionDefinitionImpl.java
===================================================================
--- projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/ConnectionDefinitionImpl.java	2010-08-16 09:09:33 UTC (rev 107629)
+++ projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/ConnectionDefinitionImpl.java	2010-08-16 09:11:11 UTC (rev 107630)
@@ -95,7 +95,7 @@
     * @return managedconnectionfactoryClass
     */
    @Override
-   public XsdString getManagedconnectionfactoryClass()
+   public XsdString getManagedConnectionFactoryClass()
    {
       return managedconnectionfactoryClass;
    }
@@ -113,7 +113,7 @@
     * @return connectionfactoryInterface
     */
    @Override
-   public XsdString getConnectionfactoryInterface()
+   public XsdString getConnectionFactoryInterface()
    {
       return connectionfactoryInterface;
    }
@@ -122,7 +122,7 @@
     * @return connectionfactoryImplClass
     */
    @Override
-   public XsdString getConnectionfactoryImplClass()
+   public XsdString getConnectionFactoryImplClass()
    {
       return connectionfactoryImplClass;
    }

Modified: projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/OutboundResourceAdapterImpl.java
===================================================================
--- projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/OutboundResourceAdapterImpl.java	2010-08-16 09:09:33 UTC (rev 107629)
+++ projects/jboss-jca/trunk/common/src/main/java/org/jboss/jca/common/metadata/ra/common/OutboundResourceAdapterImpl.java	2010-08-16 09:11:11 UTC (rev 107630)
@@ -238,8 +238,8 @@
       if (this.getConnectionDefinitions() == null || this.getConnectionDefinitions().size() == 0)
          return false;
       ConnectionDefinition cdm = this.getConnectionDefinitions().get(0);
-      if (cdm.getManagedconnectionfactoryClass() == null || cdm.getConnectionfactoryInterface() == null
-            || cdm.getConnectionfactoryImplClass() == null || cdm.getConnectionInterface() == null
+      if (cdm.getManagedConnectionFactoryClass() == null || cdm.getConnectionFactoryInterface() == null
+            || cdm.getConnectionFactoryImplClass() == null || cdm.getConnectionInterface() == null
             || cdm.getConnectionImplClass() == null)
          return false;
 
@@ -264,7 +264,7 @@
             boolean isNew = true;
             for (ConnectionDefinition lcd : this.connectionDefinition)
             {
-               if (rcd.getManagedconnectionfactoryClass().equals(lcd.getManagedconnectionfactoryClass()))
+               if (rcd.getManagedConnectionFactoryClass().equals(lcd.getManagedConnectionFactoryClass()))
                {
                   newConnectionDefinition.remove(lcd);
                   newConnectionDefinition.add(lcd.merge(rcd));

Modified: projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java
===================================================================
--- projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java	2010-08-16 09:09:33 UTC (rev 107629)
+++ projects/jboss-jca/trunk/deployers/src/main/java/org/jboss/jca/deployers/fungal/RADeployer.java	2010-08-16 09:11:11 UTC (rev 107630)
@@ -548,7 +548,7 @@
                         partialFailures =
                               validateArchive(url, Arrays
                                     .asList((Validate) new ValidateClass(Key.MANAGED_CONNECTION_FACTORY, cdMeta
-                                          .getManagedconnectionfactoryClass().getValue(), cl, cdMeta
+                                          .getManagedConnectionFactoryClass().getValue(), cl, cdMeta
                                           .getConfigProperties())));
                         if (partialFailures != null)
                         {
@@ -559,7 +559,7 @@
                         if (!(getArchiveValidationFailOnError() && hasFailuresLevel(failures, Severity.ERROR)))
                         {
                            ManagedConnectionFactory mcf =
-                                 (ManagedConnectionFactory) initAndInject(cdMeta.getManagedconnectionfactoryClass()
+                                 (ManagedConnectionFactory) initAndInject(cdMeta.getManagedConnectionFactoryClass()
                                        .getValue(), cdMeta
                                        .getConfigProperties(), cl);
 

Modified: projects/jboss-jca/trunk/validator/src/main/java/org/jboss/jca/validator/Validation.java
===================================================================
--- projects/jboss-jca/trunk/validator/src/main/java/org/jboss/jca/validator/Validation.java	2010-08-16 09:09:33 UTC (rev 107629)
+++ projects/jboss-jca/trunk/validator/src/main/java/org/jboss/jca/validator/Validation.java	2010-08-16 09:11:11 UTC (rev 107630)
@@ -292,11 +292,11 @@
          {
             for (ConnectionDefinition cdMeta : cdMetas)
             {
-               if (cdMeta.getManagedconnectionfactoryClass() != null)
+               if (cdMeta.getManagedConnectionFactoryClass() != null)
                {
                   try
                   {
-                     Class<?> clazz = Class.forName(cdMeta.getManagedconnectionfactoryClass().getValue(), true, cl);
+                     Class<?> clazz = Class.forName(cdMeta.getManagedConnectionFactoryClass().getValue(), true, cl);
                      List<? extends ConfigProperty> configProperties = cdMeta.getConfigProperties();
 
                      ValidateClass vc = new ValidateClass(Key.MANAGED_CONNECTION_FACTORY, clazz, configProperties);