[jboss-cvs] JBossAS SVN: r99596 - projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi.

[jboss-cvs-commits at lists.jboss.org]

Author: jaikiran
Date: 2010-01-19 08:10:14 -0500 (Tue, 19 Jan 2010)
New Revision: 99596

Modified:
   projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/AbstractNoInterfaceViewJNDIBinder.java
   projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatefulNoInterfaceJNDIBinder.java
   projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatelessNoInterfaceJNDIBinder.java
Log:
EJBTHREE-1993 Print out the no-interface jndi binding at INFO level

Modified: projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/AbstractNoInterfaceViewJNDIBinder.java
===================================================================
--- projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/AbstractNoInterfaceViewJNDIBinder.java	2010-01-19 13:02:12 UTC (rev 99595)
+++ projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/AbstractNoInterfaceViewJNDIBinder.java	2010-01-19 13:10:14 UTC (rev 99596)
@@ -24,6 +24,7 @@
 import org.jboss.ejb3.nointerface.impl.invocationhandler.NoInterfaceViewInvocationHandler;
 import org.jboss.ejb3.nointerface.spi.jndi.NoInterfaceViewJNDIBinder;
 import org.jboss.kernel.spi.dependency.KernelControllerContext;
+import org.jboss.logging.Logger;
 import org.jboss.metadata.ejb.jboss.JBossSessionBean31MetaData;
 import org.jboss.metadata.ejb.jboss.jndi.resolver.impl.JNDIPolicyBasedJNDINameResolverFactory;
 import org.jboss.metadata.ejb.jboss.jndi.resolver.spi.SessionBean31JNDINameResolver;
@@ -40,6 +41,11 @@
 {
 
    /**
+    * Logger
+    */
+   private static Logger logger = Logger.getLogger(AbstractNoInterfaceViewJNDIBinder.class);
+   
+   /**
     * The endpoint context which will be used while creating the {@link NoInterfaceViewInvocationHandler}
     */
    protected KernelControllerContext endpointContext;
@@ -82,4 +88,21 @@
       return JNDIPolicyBasedJNDINameResolverFactory.getJNDINameResolver(sessionBean, jndiBindingPolicy);
    }
 
+   /**
+    * Utility method to log the jndi name, to which the no-interface view of the bean represented
+    * by the <code>sessionBean<code>, will be bound.
+    * 
+    * @param sessionBeanMetaData Session bean metadata
+    * @param noInterfaceViewJNDIName The jndi name to which the no-interface view will be bound
+    */
+   protected void prettyPrintJNDIBindingInfo(JBossSessionBean31MetaData sessionBeanMetaData, String noInterfaceViewJNDIName)
+   {
+      StringBuffer sb = new StringBuffer();
+      sb.append("Binding the following entry in Global JNDI:\n\n");
+      sb.append("\t");
+      sb.append(noInterfaceViewJNDIName);
+      sb.append(" - EJB3.1 no-interface view\n");
+      
+      logger.info(sb);
+   }
 }

Modified: projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatefulNoInterfaceJNDIBinder.java
===================================================================
--- projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatefulNoInterfaceJNDIBinder.java	2010-01-19 13:02:12 UTC (rev 99595)
+++ projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatefulNoInterfaceJNDIBinder.java	2010-01-19 13:10:14 UTC (rev 99596)
@@ -57,7 +57,6 @@
     */
    private static final String NO_INTERFACE_STATEFUL_PROXY_FACTORY_JNDI_NAME_SUFFIX = "/no-interface-stateful-proxyfactory";
 
-
    /**
     * Constructor
     * @param beanClass The bean class
@@ -90,8 +89,8 @@
 
       // This factory will be bound to JNDI and will be invoked (through an objectfactory) to create
       // the no-interface view for a SFSB
-      StatefulNoInterfaceViewFacade statefulNoInterfaceViewFactory = new StatefulNoInterfaceViewFacade(
-            beanClass, this.endpointContext);
+      StatefulNoInterfaceViewFacade statefulNoInterfaceViewFactory = new StatefulNoInterfaceViewFacade(beanClass,
+            this.endpointContext);
 
       // TODO - Needs to be a proper jndi name for the factory
       String statefulProxyFactoryJndiName = beanMetaData.getEjbName()
@@ -111,8 +110,10 @@
       reference.add(refAddr);
 
       String noInterfaceJndiName = this.getJNDINameResolver(beanMetaData).resolveNoInterfaceJNDIName(beanMetaData);
+      // log the jndi binding information 
+      this.prettyPrintJNDIBindingInfo(beanMetaData, noInterfaceJndiName);
+      // bind to jndi
       jndiCtx.bind(noInterfaceJndiName, reference);
-      logger.info("Bound the no-interface view for bean " + beanClass + " to jndi at " + noInterfaceJndiName);
 
       return noInterfaceJndiName;
 

Modified: projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatelessNoInterfaceJNDIBinder.java
===================================================================
--- projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatelessNoInterfaceJNDIBinder.java	2010-01-19 13:02:12 UTC (rev 99595)
+++ projects/ejb3/components/nointerface/trunk/impl/src/main/java/org/jboss/ejb3/nointerface/impl/jndi/StatelessNoInterfaceJNDIBinder.java	2010-01-19 13:10:14 UTC (rev 99596)
@@ -87,11 +87,13 @@
       {
          throw new RuntimeException("Could not create no-interface view for bean class: " + beanClass, e);
       }
-      // bind
+      // get no-interface view jndi name
       String noInterfaceJndiName = this.getJNDINameResolver(beanMetaData).resolveNoInterfaceJNDIName(beanMetaData);
+      // log the no-interface view jndi binding info
+      this.prettyPrintJNDIBindingInfo(beanMetaData, noInterfaceJndiName);
+      // bind to jndi
       NonSerializableFactory.rebind(jndiCtx, noInterfaceJndiName, noInterfaceView, true);
-
-      logger.info("Bound the no-interface view for bean " + beanClass + " to jndi at " + noInterfaceJndiName);
+      
       return noInterfaceJndiName;
    }