[jboss-cvs] JBossAS SVN: r108671 - branches/JBPAPP_4_3_0_GA_CP08_JBPAPP-4094/tomcat/src/main/org/jboss/web/tomcat/service/session.

[jboss-cvs-commits at lists.jboss.org]

Author: dereed
Date: 2010-10-19 15:28:04 -0400 (Tue, 19 Oct 2010)
New Revision: 108671

Modified:
   branches/JBPAPP_4_3_0_GA_CP08_JBPAPP-4094/tomcat/src/main/org/jboss/web/tomcat/service/session/JBossCacheManager.java
Log:
[JBPAPP-5271] port JBPAPP-4094 to EAP 4.3 CP08


Modified: branches/JBPAPP_4_3_0_GA_CP08_JBPAPP-4094/tomcat/src/main/org/jboss/web/tomcat/service/session/JBossCacheManager.java
===================================================================
--- branches/JBPAPP_4_3_0_GA_CP08_JBPAPP-4094/tomcat/src/main/org/jboss/web/tomcat/service/session/JBossCacheManager.java	2010-10-19 18:51:36 UTC (rev 108670)
+++ branches/JBPAPP_4_3_0_GA_CP08_JBPAPP-4094/tomcat/src/main/org/jboss/web/tomcat/service/session/JBossCacheManager.java	2010-10-19 19:28:04 UTC (rev 108671)
@@ -1419,35 +1419,15 @@
       }
       else
       {
-         // Expire the session
-         // DON'T SYNCHRONIZE ON SESSION HERE -- isValid() and
-         // expire() are meant to be multi-threaded and synchronize
-         // properly internally; synchronizing externally can lead
-         // to deadlocks!!
-         boolean notify = false; // Don't notify listeners. SRV.10.7
-                                 // allows this, and sending notifications
-                                 // leads to all sorts of issues; e.g.
-                                 // circular calls with ClusteredSSO
-         boolean localCall = false; // this call originated from the cache;
-                                    // we have already removed session
-         boolean localOnly = true; // Don't pass attr removals to cache
+         // JBAS-4094 Don't call session expire as that can lead to deadlock
+         // Just do the bare minimum to remove the session
+         session.setValid(false);
          
-         // Ensure the correct TCL is in place
-         ClassLoader prevTcl = Thread.currentThread().getContextClassLoader();         
-         try
-         {
-            Thread.currentThread().setContextClassLoader(tcl_);
-            session.expire(notify, localCall, localOnly, ClusteredSessionNotificationCause.TIMEOUT);
-         }
-         finally
-         {
-            Thread.currentThread().setContextClassLoader(prevTcl);
-         }
-
          // Remove any stats for this session
          stats_.removeStats(realId);
          
-         // Update counter.
+         // Update counters.
+         expiredCounter_++;
          activeCounter_--;
       }
    }