[jboss-cvs] Picketbox SVN: r533 - branches/eap62/picketbox-infinispan/src/main/java/org/jboss/security/authentication.

[jboss-cvs-commits at lists.jboss.org]

Author: dehort
Date: 2014-04-04 13:18:48 -0400 (Fri, 04 Apr 2014)
New Revision: 533

Modified:
   branches/eap62/picketbox-infinispan/src/main/java/org/jboss/security/authentication/JBossCachedAuthenticationManager.java
Log:
[bz-1069886] Fixed an issue where SecureIdentityLoginModule (and ConfiguredIdentityLoginModule) results are not cached by the JAAS cache


Modified: branches/eap62/picketbox-infinispan/src/main/java/org/jboss/security/authentication/JBossCachedAuthenticationManager.java
===================================================================
--- branches/eap62/picketbox-infinispan/src/main/java/org/jboss/security/authentication/JBossCachedAuthenticationManager.java	2014-03-18 21:06:46 UTC (rev 532)
+++ branches/eap62/picketbox-infinispan/src/main/java/org/jboss/security/authentication/JBossCachedAuthenticationManager.java	2014-04-04 17:18:48 UTC (rev 533)
@@ -133,7 +133,7 @@
    public boolean isValid(Principal principal, Object credential, Subject activeSubject)
    {
       // first check cache
-      DomainInfo cachedEntry = getCacheInfo(principal);
+      DomainInfo cachedEntry = getCacheInfo(principal != null ? principal : new org.jboss.security.SimplePrincipal("null"));
       PicketBoxLogger.LOGGER.traceBeginIsValid(principal, cachedEntry != null ? cachedEntry.toString() : null);
 
       boolean isValid = false;
@@ -423,7 +423,7 @@
    private Subject updateCache(LoginContext loginContext, Subject subject, Principal principal, Object credential)
    {
       // If we don't have a cache there is nothing to update
-      if (domainCache == null || principal == null)
+      if (domainCache == null)
          return subject;
 
       DomainInfo info = new DomainInfo();
@@ -470,7 +470,7 @@
 
       // If the user already exists another login is active. Currently
       // only one is allowed so remove the old and insert the new
-      domainCache.put(principal, info);
+      domainCache.put(principal != null ? principal : new org.jboss.security.SimplePrincipal("null"), info);
       PicketBoxLogger.LOGGER.traceInsertedCacheInfo(info.toString());
       return info.subject;
    }
@@ -507,4 +507,4 @@
          }
       }
    }
-}
\ No newline at end of file
+}