[jboss-dev-forums] [Design the new POJO MicroContainer] - Re: Precedence

[adrian@jboss.org]

What is this? It is not a fix to change the test. 
You're supposed to make the tests pass, not change them!

The orders in those tests were the correct ones.

There's NO POINT having regression tests if you modify the tests
because you introduced a regression. :-)


  | 
  | > Modified: projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerFlowUnitTestCase.java
  | > ===================================================================
  | > --- projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerFlowUnitTestCase.java	2007-07-06 12:53:54 UTC (rev 63864)
  | > +++ projects/microcontainer/trunk/deployers-impl/src/tests/org/jboss/test/deployers/deployer/test/DeployerFlowUnitTestCase.java	2007-07-06 13:05:54 UTC (rev 63865)
  | > @@ -288,7 +288,7 @@
  | >        assertEquals(6, deployer3.getUndeployOrder());
  | >        assertEquals(5, deployer4.getUndeployOrder());
  | >     }
  | > -   
  | > +
  | >     public void testMultipleOutput() throws Exception
  | >     {
  | >        DeployerClient main = createMainDeployer();
  | > @@ -453,11 +453,11 @@
  | >        main.addDeployment(deployment);
  | >        main.process();
  | >        
  | > -      assertEquals(1, deployer1.getDeployOrder());
  | > -      assertEquals(2, deployer2.getDeployOrder());
  | > -      assertEquals(3, deployer3.getDeployOrder());
  | > -      assertEquals(4, deployer4.getDeployOrder());
  | > -      assertEquals(5, deployer5.getDeployOrder());
  | > +      assertEquals(5, deployer1.getDeployOrder());
  | > +      assertEquals(4, deployer2.getDeployOrder());
  | > +      assertEquals(1, deployer3.getDeployOrder());
  | > +      assertEquals(2, deployer4.getDeployOrder());
  | > +      assertEquals(3, deployer5.getDeployOrder());
  | >        assertEquals(6, deployer6.getDeployOrder());
  | >        assertEquals(-1, deployer1.getUndeployOrder());
  | >        assertEquals(-1, deployer2.getUndeployOrder());
  | > @@ -469,33 +469,33 @@
  | >        main.removeDeployment(deployment);
  | >        main.process();
  | >        
  | > -      assertEquals(1, deployer1.getDeployOrder());
  | > -      assertEquals(2, deployer2.getDeployOrder());
  | > -      assertEquals(3, deployer3.getDeployOrder());
  | > -      assertEquals(4, deployer4.getDeployOrder());
  | > -      assertEquals(5, deployer5.getDeployOrder());
  | > +      assertEquals(5, deployer1.getDeployOrder());
  | > +      assertEquals(4, deployer2.getDeployOrder());
  | > +      assertEquals(1, deployer3.getDeployOrder());
  | > +      assertEquals(2, deployer4.getDeployOrder());
  | > +      assertEquals(3, deployer5.getDeployOrder());
  | >        assertEquals(6, deployer6.getDeployOrder());
  | > -      assertEquals(12, deployer1.getUndeployOrder());
  | > -      assertEquals(11, deployer2.getUndeployOrder());
  | > -      assertEquals(10, deployer3.getUndeployOrder());
  | > -      assertEquals(9, deployer4.getUndeployOrder());
  | > -      assertEquals(8, deployer5.getUndeployOrder());
  | > +      assertEquals(8, deployer1.getUndeployOrder());
  | > +      assertEquals(9, deployer2.getUndeployOrder());
  | > +      assertEquals(12, deployer3.getUndeployOrder());
  | > +      assertEquals(11, deployer4.getUndeployOrder());
  | > +      assertEquals(10, deployer5.getUndeployOrder());
  | >        assertEquals(7, deployer6.getUndeployOrder());
  | >  
  | >        main.addDeployment(deployment);
  | >        main.process();
  | >        
  | > -      assertEquals(13, deployer1.getDeployOrder());
  | > -      assertEquals(14, deployer2.getDeployOrder());
  | > -      assertEquals(15, deployer3.getDeployOrder());
  | > -      assertEquals(16, deployer4.getDeployOrder());
  | > -      assertEquals(17, deployer5.getDeployOrder());
  | > +      assertEquals(17, deployer1.getDeployOrder());
  | > +      assertEquals(16, deployer2.getDeployOrder());
  | > +      assertEquals(13, deployer3.getDeployOrder());
  | > +      assertEquals(14, deployer4.getDeployOrder());
  | > +      assertEquals(15, deployer5.getDeployOrder());
  | >        assertEquals(18, deployer6.getDeployOrder());
  | > -      assertEquals(12, deployer1.getUndeployOrder());
  | > -      assertEquals(11, deployer2.getUndeployOrder());
  | > -      assertEquals(10, deployer3.getUndeployOrder());
  | > -      assertEquals(9, deployer4.getUndeployOrder());
  | > -      assertEquals(8, deployer5.getUndeployOrder());
  | > +      assertEquals(8, deployer1.getUndeployOrder());
  | > +      assertEquals(9, deployer2.getUndeployOrder());
  | > +      assertEquals(12, deployer3.getUndeployOrder());
  | > +      assertEquals(11, deployer4.getUndeployOrder());
  | > +      assertEquals(10, deployer5.getUndeployOrder());
  | >        assertEquals(7, deployer6.getUndeployOrder());
  | 

View the original post : http://www.jboss.com/index.html?module=bb&op=viewtopic&p=4061289#4061289

Reply to the post : http://www.jboss.com/index.html?module=bb&op=posting&mode=reply&p=4061289