<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
JCA / Datasources in domain.xml
</h3>
<span style="margin-bottom: 10px;">
reply from <a href="http://community.jboss.org/people/maeste">Stefano Maestri</a> in <i>JBoss AS7 Development</i> - <a href="http://community.jboss.org/message/557500#557500">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><blockquote class="jive-quote"><p>Jesper Pedersen wrote:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Looks good. A couple of comments</p><p>I think we should remove the -settings suffix - f.ex. 'validation-settings' -> 'validation'.</p></blockquote><p>Done in my last commit, with changes to metadatas interfaces and implementation according.</p><p>In this commit I've also changed a bit xsd to adhere xsd name comnvention of AS7 (mainly *Type for type definition instead of *ComplexType or *Value I've used before for complex and simple types) as I discussed in IRC with David.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><blockquote class="jive-quote"><p>Jesper Pedersen wrote:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Also we need a way to pass in configuration properties and their values to the user supplied classes like the validation connection checker and the exception sorter to allow user to override default values in the implementation. F.ex. overriding the timeout value for the database ping method:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-xml"><span class="jive-xml-tag"><valid-connection-checker></span>
<span class="jive-xml-tag"><class-name></span>com.mycompany.MyConnectionChecker<span class="jive-xml-tag"></class-name></span>
  <span class="jive-xml-tag"><property name="Timeout"></span>1<span class="jive-xml-tag"></property></span>
<span class="jive-xml-tag"></valid-connection-checker></span>
</code></pre>
<p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p>
</blockquote><p>And what about making class name an attribute? It wpuld results in a more compact xml in case of no property, and an easier to read one in case of multiple config property:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre jivemacro="quote"><pre><pre class="jive-pre"><code class="jive-code jive-xml">
<span class="jive-xml-tag"><valid-connection-checker class-name="com.mycompany.MyConnectionChecker" /></span>
<span class="jive-xml-tag"><valid-connection-checker class-name="com.mycompany.MyConnectionChecker"></span>
     <span class="jive-xml-tag"><property name="Timeout"></span>1<span class="jive-xml-tag"></property></span>
     <span class="jive-xml-tag"><property name="OtherProperty"></span>2<span class="jive-xml-tag"></property></span>
<span class="jive-xml-tag"></valid-connection-checker></span>
</code></pre>
</pre>
</pre><blockquote class="jive-quote"><p>Jesper Pedersen wrote:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>However, that can come later (post M1), as we need to enhance the JDBC resource adapter with this feature too.</p></blockquote><p>Well, if we can agree at least on the xsd structure I'd prefer to change xsd now, to limit (as much as possible) changes in metadatas api.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>best regards</p><p>S.</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/557500#557500">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss AS7 Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2225">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>