<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
AbstractStructureDeployer.getRelativePath fails to handle unrelated paths
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/flavia.rainone%40jboss.com">Flavia Rainone</a> in <i>JBoss Microcontainer Development</i> - <a href="http://community.jboss.org/message/561697#561697">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p class="western" style="margin-bottom: 0cm;">For the weld-int <a class="jive-link-external-small" href="https://community.jboss.org/message/561400">tests I've been working on</a>, I ended up finding a problem involving the case where a classpath entry in the manifest file generates a faulty classpath entry in the deployment context.</p><p class="western" style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p class="western" style="margin-bottom: 0cm;">In the test I'm performing, I deploy a file named weld-translator.jar that lacks a class. The class needed for the deployment to be successful is in weld-translator-lib.jar, located in $JBOSS_HOME/server/all (or anywhere you name in the filesystem, except in the deploy dir). This jar is referenced by a relative classpath entry in the weld-translator.jar manifest file.</p><p class="western" style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p class="western" style="margin-bottom: 0cm;">The problem is noticed when WeldFilesDeployer checks on whether the file weld-translator-lib.jar/META-INF/beans.xml exists. The exists method returns false when it should return true.</p><p class="western" style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p class="western" style="margin-bottom: 0cm;">What I discovered is that:</p><ol><li>VFSUtils.addManifestLocations      transforms the relative Classpath entry found in the manifest file      (../weld-translator-lib.jar) into an absolute path      ($JBOSS_HOME/server/all/weld-translator-lib.jar)</li><li>AbstractStructureDeployer.getRelativePath      was supposed to revert it to a relative path, but fails to do so,      instead, it returns the absolute path      $JBOSS_HOME/server/all/weld-translator/lib.jar</li><li>VFSStructureBuilder      assumes that the path is relative, and, for that reason, it assembles the following classpath with the goal of getting the absolute classpath: $JBOSS_HOME/server/all/deploy/weld-translator.jar/$JBOSS_HOME/server/all/weld-translator-lib.jar</li><li>WeldFilesDeployers uses the path generated in the step above to append the suffix META-INF/beans.xml. That's why it fails to find it.</li></ol><p class="western" style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p class="western" style="margin-bottom: 0cm;">I created a <a class="jive-link-external-small" href="https://jira.jboss.org/browse/JBDEPLOY-265">Jira</a> to fix AbstractStructureDeployer.getRelativePath, and I wrote a fix for it as well.</p><p class="western" style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">         <font color="darkgreen">// Assuming that child and parent don't have a parent -> child relationship</font>
         <font color="darkgreen">// but instead, have a common path with different suffixes</font>
         VirtualFile tempFile = parent;
         StringBuilder relativePath = <font color="navy"><b>new</b></font> StringBuilder();
         <font color="darkgreen">// find the prefix that child shares with parent (in tempFile)</font>
         <font color="navy"><b>while</b></font>(!childPath.startsWith(tempFile.getPathName()))
         <font color="navy">{</font>
            relativePath.append(<font color="red">"/.."</font>); <font color="darkgreen">// for every level we need to go up in the file system </font>
            tempFile = tempFile.getParent();
         <font color="navy">}</font>
         relativePath.append(childPath.substring(tempFile.getPathName().length()));
         childPath = relativePath.toString().substring(1);
</code></pre><p class="western" style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p class="western" style="margin-bottom: 0cm;">Ales, can you please let me know if everything is ok? I couldn't find tests for getRelativePath... should I write one for JBDEPLOY-265? Where should that test be added to?</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/561697#561697">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss Microcontainer Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2115">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>