<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="http://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Re: META-INF/services for module extensions - question/issue
</h3>
<span style="margin-bottom: 10px;">
created by <a href="http://community.jboss.org/people/lmcdasi">Dan Sirbu</a> in <i>JBoss AS7 Development</i> - <a href="http://community.jboss.org/message/625592#625592">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Hi,</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   The good news is that we are converging in ideas <span> (+) </span>.  No frustration - yet <span> ;) </span></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   The bad news is that somehow I do not get what I think I should get <span> :0 </span> . And what from design point of view sounds correct to me.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   My example is a lot more complicated than I what I explained here. I do have a ModuleExtension that depends on a Module#1, then Module#1 dependes on Module#2 and few others for example, and Module#1, Module#2 do have exposed services. </p><p>   If I have to 'customize' ModuleExtension to kistart Module#1 - then again I do not have an issue since it is jboss module specific. BUT and from here on we diverge in opinions .... looks like <span> ;) </span></p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>  Module#1 does also a ServiceLoader.load(ServiceAPIFromModule#2.class) - no extra argument here when the ModuleExtension executes the ServiceAPIFromModule#1. And that does not work neither - for same above issues.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   Now - if you ask me to add a second argument to ServiceLoader in Module#1 - then there is a no go - because Module#1 may be a 3rd party product that I cannot change, as example. Thus the ServiceLoader.load with one argument is the only option that can be available.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   At the same time, Module#1 code should not be impacted by the jboss-module/as7 architecture - one same simple reason: portability.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   Any existing jar file can be always be viewed as a Module - but not as an extension - which is ok !</p><p>   Thus as a Module, if it's using ServiceLoader with one argument it should work with no code changes ! Otherwise you impleciltely are telling me that the exiting jar file is no longer portable when using it from ModuleExtension ! And this makes jboss-modules not to be flexible and imposes extra constrains that, to me, do not look to be required.</p><p>   Think about that jar file can be used as a Module from a WAr, RAR and why not from a ModuleExtension ?!?</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>   Again, once I am in the Module#1 code I should be able to do a ServiceLoader.load - with only one argument as any war file does when it is deployed - if the module.xml has set a dependecy on a module and if services="import" has been set in the ModuleExtension as in the war. </p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>  So far, I am not getting that ! And again, even if it looks stuborn, I think from design point of view I should !</p><div class="mcePaste" id="_mcePaste" style="position: absolute; top: 19px; left: 0px;"></div><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>BR,</p><p>Dan S.</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="http://community.jboss.org/message/625592#625592">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in JBoss AS7 Development at <a href="http://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2225">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>