<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.0 Transitional//EN">
<html>
<body link="#355491" alink="#4262a1" vlink="#355491" style="background: #e2e2e2; margin: 0; padding: 20px;">
<div>
<table cellpadding="0" bgcolor="#FFFFFF" border="0" cellspacing="0" style="border: 1px solid #dadada; margin-bottom: 30px; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td>
<table border="0" cellpadding="0" cellspacing="0" bgcolor="#FFFFFF" style="border: solid 2px #ccc; background: #dadada; width: 100%; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tbody>
<tr>
<td bgcolor="#000000" valign="middle" height="58px" style="border-bottom: 1px solid #ccc; padding: 20px; -moz-border-radius-topleft: 3px; -moz-border-radius-topright: 3px; -webkit-border-top-right-radius: 5px; -webkit-border-top-left-radius: 5px;">
<h1 style="color: #333333; font: bold 22px Arial, Helvetica, sans-serif; margin: 0; display: block !important;">
<!-- To have a header image/logo replace the name below with your img tag -->
<!-- Email clients will render the images when the message is read so any image -->
<!-- must be made available on a public server, so that all recipients can load the image. -->
<a href="https://community.jboss.org/index.jspa" style="text-decoration: none; color: #E1E1E1">JBoss Community</a></h1>
</td>
</tr>
<tr>
<td bgcolor="#FFFFFF" style="font: normal 12px Arial, Helvetica, sans-serif; color:#333333; padding: 20px; -moz-border-radius-bottomleft: 4px; -moz-border-radius-bottomright: 4px; -webkit-border-bottom-right-radius: 5px; -webkit-border-bottom-left-radius: 5px;"><h3 style="margin: 10px 0 5px; font-size: 17px; font-weight: normal;">
Re: methods getConstraint and setConstraint in Split nodes don't work.
</h3>
<span style="margin-bottom: 10px;">
created by <a href="https://community.jboss.org/people/marbu">Mar Bartolomé</a> in <i>jBPM Development</i> - <a href="https://community.jboss.org/message/740934#740934">View the full discussion</a>
</span>
<hr style="margin: 20px 0; border: none; background-color: #dadada; height: 1px;">
<div class="jive-rendered-content"><p>Ok, I made some more findings on my own.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Seems that whenever a split node get parsed (in org.jbpm.compiler.ProcessBuilderImpl), for every constraint it contains, a new drools rule is created, with the constraint condition:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">    <font color="navy"><b>private</b></font> String createSplitRule(Process process,
                                   Connection connection,
                                   String constraint) <font color="navy">{</font>
        <font color="navy"><b>return</b></font>
            <font color="red">"rule \"RuleFlow-Split-"</font> + process.getId() + <font color="red">"-"</font> +
                ((org.jbpm.workflow.core.Node) connection.getFrom()).getUniqueId() + <font color="red">"-"</font> +
                ((org.jbpm.workflow.core.Node) connection.getTo()).getUniqueId() + <font color="red">"-"</font> +
                connection.getToType() + <font color="red">"\" \n"</font> +
            <font color="red">"      ruleflow-group \"DROOLS_SYSTEM\" \n"</font> +
            <font color="red">"    when \n"</font> +
            <font color="red">"      "</font> + constraint + <font color="red">"\n"</font> +
            <font color="red">"    then \n"</font> +
            <font color="red">"end \n\n"</font>;
    <font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Then, when the node gets later evaluated at runtime, (at org.jbpm.workflow.instance.node.SplitInstance) the constraints get evaluated, with an or.jbpm.process.instance.impl.RuleConstraintEvaluator. This evaluation returns true if the drools rule created at parse time is active.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>So, efectively, the setConstraint method does absolutely nothing, as the evaluation only depends on the drools rule, and this doesn't get modified at all.</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>HOWEVER! notice how in the createSplitRule method, it actually uses the text in the constraint to add it as a drools rule. This text seems that should in fact be present in the constraints in the split node, or the call to evaluate done in ProcessBuilderImpl could not work:</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">    <font color="navy"><b>private</b></font> <font color="navy"><b>void</b></font> generateRules(Node[] nodes, Process process, StringBuffer builder) <font color="navy">{</font>
        <font color="navy"><b>for</b></font> ( <font color="navy"><b>int</b></font> i = 0; i < nodes.length; i++ ) <font color="navy">{</font>
            <font color="navy"><b>if</b></font> ( nodes[i] <font color="navy"><b>instanceof</b></font> Split ) <font color="navy">{</font>
                Split split = (Split) nodes[i];
                <font color="navy"><b>if</b></font> ( split.getType() == Split.TYPE_XOR || split.getType() == Split.TYPE_OR ) <font color="navy">{</font>
                    <font color="navy"><b>for</b></font> ( Connection connection : split.getDefaultOutgoingConnections() ) <font color="navy">{</font>
                        Constraint constraint = split.getConstraint( connection );
                        <font color="navy"><b>if</b></font> ( <font color="red">"rule"</font>.equals( constraint.getType() ) ) <font color="navy">{</font>
                            builder.append( createSplitRule( process,
                                                             connection,
                                                             split.getConstraint( connection ).getConstraint() ) );
                        <font color="navy">}</font>
                    <font color="navy">}</font>
                <font color="navy">}</font>
 
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>This connection, I reckon, is set at parse time in org.jbpm.bpmn2.xml.ProcessHandler, and it's obtained from a SequenceFlow object, wich is a direct mapping of a bpmn2 sequence flow (and completely inaccessible once the parsing is done, I assume).</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><pre class="jive-pre"><code class="jive-code jive-java">            <font color="navy"><b>for</b></font> (SequenceFlow connection: connections) <font color="navy">{</font>
 
                [ ... ]
 
                <font color="navy"><b>if</b></font> (source <font color="navy"><b>instanceof</b></font> Split) <font color="navy">{</font>
                    Split split = (Split) source;
                    Constraint constraint = <font color="navy"><b>new</b></font> ConstraintImpl();
 
                    [ ... ]
 
                    <font color="navy"><b>if</b></font> (connection.getExpression() != <font color="navy"><b>null</b></font>) <font color="navy">{</font>
                        constraint.setConstraint(connection.getExpression());
                    <font color="navy">}</font>
 
                    [ ... ]
 
                    split.addConstraint(
                        <font color="navy"><b>new</b></font> ConnectionRef(target.getId(), NodeImpl.CONNECTION_DEFAULT_TYPE),
                        constraint);
                <font color="navy">}</font>
</code></pre><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>What I still don't undestand is how the getConstraint() method at Split is returning null, if it seems reasonable that it should at least contain the constraint text (or else, the drools rule wouldn't get created, and the constraint wouldn't be evaluated at runtime).</p><p style="min-height: 8pt; height: 8pt; padding: 0px;"> </p><p>Please, any help would be appreciated.</p></div>
<div style="background-color: #f4f4f4; padding: 10px; margin-top: 20px;">
<p style="margin: 0;">Reply to this message by <a href="https://community.jboss.org/message/740934#740934">going to Community</a></p>
<p style="margin: 0;">Start a new discussion in jBPM Development at <a href="https://community.jboss.org/choose-container!input.jspa?contentType=1&containerType=14&container=2035">Community</a></p>
</div></td>
</tr>
</tbody>
</table>
</td>
</tr>
</tbody>
</table>
</div>
</body>
</html>