[jboss-dev] Re: New integration project

[Adrian]

On Mon, 2007-07-09 at 13:29 +0100, Jonathan Halliday wrote:
> org.jboss.iiop.CorbaORBService;

OK. Needs a spi.

> org.jboss.jmx.adaptor.rmi.RMIAdaptor;

Use the javax.management.MBeanServerConnector interface
that this object implements.

> org.jboss.logging.Logger;

This already is a spi, but in the commons project.
It suppose it could be moved to the integration project?

> org.jboss.mx.util.ObjectNameFactory;

This is just a convience class. It
is equivalent to new ObjectName(String), except it
rethrows MalformedObjectNameExceptions
as runtime exceptions.

In JBoss5 it is already in the J2SE project
which is a project that serves as a kind of SPI
for JDK classes that are not available
in all versions. e.g. JMX was not in JDK1.3
and there are classes in here for
DOM level 3 that where not in JDK1.4

> org.jboss.system.server.Server;

Why?

> org.jboss.system.ServiceMBeanSupport;

You don't have to use to this class.

You don't even need to implement Service or ServiceMBean
for your MBeans to be services.

For JBoss5, you should be integrating
using POJOs and -beans.xml anyway 
(if you have the time to make the conversion :-).

If you want an mbean for your POJO, simply
annotate your class with @JMX like
the clustering team have already done
for their POJOs.

> org.jboss.util.NestedRuntimeException;
> org.jboss.util.UnexpectedThrowable;

These are both from the commons project,
so I don't think it is a problem.

The NestedRuntimeException has been redundant
since Java1.4 when RuntimeException acquired a
"cause".

That's a task for somebody that is bored.
Remove the use of the Nested* classes from JBoss. :-)

-- 
xxxxxxxxxxxxxxxxxxxxxxxxxxxx
Adrian Brock
Chief Scientist
JBoss, a division of Red Hat
xxxxxxxxxxxxxxxxxxxxxxxxxxxx