[jboss-dev] AbstractTypeMetaData.preinstantiatedLookup() hides exception stacktrace

[Brian Stansberry]

Ales Justin wrote:
> Don't blame your problems on the stack trace. :-)
> 
> 1st one is obvious, and no stack trace would tell you more.

Actually not true.  It's a known (to Manik and I) issue that's already 
been addressed for JBC 2.1.0.CR4. But unless you know what 
"preinstantiated lookup" means in the log message, the fact that the 
problem occurs when the MC calls the getter method for a property before 
calling the setter to inject what's been configured, it's not at all 
clear why the problem occurred. Calling the getter before the setter 
triggered an unintended code path; that's been fixed. That the MC would 
make such a call is not intuitively obvious.

I can see not wanting to log the stack trace at WARN. Perhaps at DEBUG.

> The 2nd needs a bit more, probably 3sec of a look at xml. ;-)

I'll let you know after I figure it out. May be fast since I now know 
what "preinstantiated lookup" means. :-)

> 
> Galder Zamarreno wrote:
>> Hi,
>>
>> Just running some tests in trunk and I'm seeing some exceptions 
>> without stacktrace:
>>
>> 2008-02-11 00:54:23,416 WARN 
>> [org.jboss.beans.metadata.plugins.AbstractListMetaData] Exception in 
>> preinstantiated lookup for: 
>> TomcatClusteringEvictionConfig.evictionRegionConfigs, 
>> org.jboss.cache.config.ConfigurationException: 
>> org.jboss.cache.config.ConfigurationException: timeToLiveSeconds must 
>> be configured to a value greater than or equal to 0
>> ....
>>
>> 2008-02-11 00:54:59,867 WARN 
>> [org.jboss.beans.metadata.plugins.AbstractListMetaData] Exception in 
>> preinstantiated lookup for: 
>> EJB3SFSBEvictionConfig.evictionRegionConfigs, 
>> org.jboss.cache.config.ConfigurationException: 
>> java.lang.ClassCastException: 
>> org.jboss.cache.eviction.NullEvictionPolicyConfig
>>
>> Shouldn't AbstractTypeMetaData.preinstantiatedLookup() print the 
>> stacktrace? That would certainly help debugging them :)
>>
>> So, instead of:
>>
>> catch (Throwable t)
>> {
>>   log.warn("Exception in preinstantiated lookup for: " + beanName + 
>> "." + propertyName + ", " + t);
>> }
>>
>> do:
>>
>> catch (Throwable t)
>> {
>>   log.warn("Exception in preinstantiated lookup for: " + beanName + 
>> "." + propertyName, t);
>> }
>>
> _______________________________________________
> jboss-development mailing list
> jboss-development at lists.jboss.org
> https://lists.jboss.org/mailman/listinfo/jboss-development


-- 
Brian Stansberry
Lead, AS Clustering
JBoss, a division of Red Hat
brian.stansberry at redhat.com