[jboss-jira] [JBoss JIRA] Commented: (JGRP-449) Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4

[Brian Stansberry (JIRA)]

    [ http://jira.jboss.com/jira/browse/JGRP-449?page=comments#action_12357541 ] 
            
Brian Stansberry commented on JGRP-449:
---------------------------------------

The relevant call to down is in ClusterPartition.startService():

if (this.nodeName == null || "".equals(this.nodeName))
         this.nodeName = generateUniqueNodeName ();

java.util.HashMap staticNodeName = new java.util.HashMap();
staticNodeName.put("additional_data", this.nodeName.getBytes());
this.channel.down(new org.jgroups.Event(org.jgroups.Event.CONFIG, staticNodeName));

Michael, you mentioned "used in a few places" -- did you see others (save me some search time).

For 4.2.0.GA I'll change it so it makes that call via reflection. Presuming reverting the method signature change is not an option, I don't see how this can be handled for earlier AS releases.
      

> Changing signature of Channel.down() breaks drop in replacement with JGroups <= 2.4
> -----------------------------------------------------------------------------------
>
>                 Key: JGRP-449
>                 URL: http://jira.jboss.com/jira/browse/JGRP-449
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.5
>         Environment: JGroups 2.5 beta-1
>            Reporter: Michael Newcomb
>         Assigned To: Bela Ban
>
> Changing the signatue for Channel.down() from:
> void down(Event e);
> to:
> Object down(Event e);
> Causes NoSuchMethodError to be thrown in JBoss 4.0.5.
> This is not a super major issue (just need to recompile JBoss), but since our project doesn't like the idea of recompiling JBoss (want to get it directly from the site) it is a show stopper.
> If drop-in replacement for JGroups <= 2.4 is a requirment, something will have to be done but the result of Channel.down() is only used in a few places, so it shouldn't be too much to get it to work.
> It looks like it is just the JBoss HA service that uses Channel.down() explicitly.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira