[jboss-jira] [JBoss JIRA] Commented: (JBAS-4263) Remove JBoss version of StandardService

Anil Saldhana (JIRA) jira-events at lists.jboss.org
Wed Mar 28 17:53:50 EDT 2007


    [ http://jira.jboss.com/jira/browse/JBAS-4263?page=comments#action_12357704 ] 
            
Anil Saldhana commented on JBAS-4263:
-------------------------------------

Or atleast refactor the following piece of code out from the start() method to a protected method with the signature "protected void startConnectors()".

--------------
// Start our defined Connectors second
        synchronized (connectors) {
            for (int i = 0; i < connectors.length; i++) {
                if (connectors[i] instanceof Lifecycle)
                    ((Lifecycle) connectors[i]).start();
            }
        }

-------------

In this case, our StandardService method can override the apache StandardService class with a blank startConnectors method.

> Remove JBoss version of StandardService
> ---------------------------------------
>
>                 Key: JBAS-4263
>                 URL: http://jira.jboss.com/jira/browse/JBAS-4263
>             Project: JBoss Application Server
>          Issue Type: Task
>      Security Level: Public(Everyone can see) 
>          Components: Web (Tomcat) service
>    Affects Versions: JBossAS-5.0.0.Beta1
>            Reporter: Anil Saldhana
>         Assigned To: Remy Maucherat
>             Fix For: JBossAS-5.0.0.Beta2
>
>
> The tomcat module contains a version of StandardService that was forked to basically not start the tomcat connectors as part of the service startup, but rather the connectors are started after the JBoss server starts.
> Since the addition of Executors to the Catalina service interface, as of this morning, this StandardService class has gone stale. We will need to update this class to incorporate the new changes to the Service interface.
> Since we are using JBossWeb, I am wondering if we can make the start of the connectors configurable in StandardService of JBossWeb such that we can discard this fork of StandardService sitting in the tomcat module.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        



More information about the jboss-jira mailing list