[jboss-jira] [JBoss JIRA] Commented: (JGRP-444) RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH

[Vladimir Blagojevic (JIRA)]

    [ http://jira.jboss.com/jira/browse/JGRP-444?page=comments#action_12357930 ] 
            
Vladimir Blagojevic commented on JGRP-444:
------------------------------------------

Hi Michael,

Flush bypass was introduced for the sole reason to accomodate some functionality from multiplexer. Do you have a concrete example explaining the need for introduction of flush bypass in RequestCorrelator?



> RequestCorrelator does not respect FLUSH.FlushHeader.BYPASS_FLUSH
> -----------------------------------------------------------------
>
>                 Key: JGRP-444
>                 URL: http://jira.jboss.com/jira/browse/JGRP-444
>             Project: JGroups
>          Issue Type: Bug
>    Affects Versions: 2.5
>         Environment: 2.5 alpha 2
>            Reporter: Michael Newcomb
>         Assigned To: Vladimir Blagojevic
>             Fix For: 2.5
>
>
> private void handleRequest(Message req, Header hdr)
> {
> ...
>         rsp=req.makeReply();
>         if(rsp_buf != null)
>             rsp.setBuffer(rsp_buf);
>         rsp_hdr=new Header(Header.RSP, hdr.id, false, name);
>         rsp.putHeader(name, rsp_hdr);
>        // *************** patch *****************
>        // can't check for FLUSH.FlushHeader.BYPASS_FLUSH because it has package protection, so just check for FLUSH header
>        //
>         if (req.getHeader(org.jgroups.protocols.pbcast.FLUSH.NAME) != null)
>         {
>           rsp.putHeader(org.jgroups.protocols.pbcast.FLUSH.NAME,
>                         new org.jgroups.protocols.pbcast.FLUSH.FlushHeader(org.jgroups.protocols.pbcast.FLUSH.FlushHeader.FLUSH_BYPASS));
>         }
>        // *************** patch *****************
>         if(log.isTraceEnabled())
>             log.trace(new StringBuffer("sending rsp for ").append(rsp_hdr.id).append(" to ").append(rsp.getDest()));
> ...
> }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira