[jboss-jira] [JBoss JIRA] Commented: (JBRULES-1254) drools-repository/jbrms should not force log4j and slf4j-log4j12 (it should be test scoped), only slf4j-api

[Geoffrey De Smet (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBRULES-1254?page=comments#action_12380876 ] 
            
Geoffrey De Smet commented on JBRULES-1254:
-------------------------------------------

it looks like jbrms is also used straight out of the box, as a war.
And not just extended by a company x's war, who will want to choose their logging implementation.

In the first case, they will want an out of the box logging implementation,
so you might want to make
slf4j-log4j12 and log4j scope "runtime" and optional "true".
This means they will be included in the "standalone jbrms war", but by default excluded if company x extends the jbrms war (and allow company x to choose their logging implementation).

> drools-repository/jbrms should not force log4j and slf4j-log4j12 (it should be test scoped), only slf4j-api
> -----------------------------------------------------------------------------------------------------------
>
>                 Key: JBRULES-1254
>                 URL: http://jira.jboss.com/jira/browse/JBRULES-1254
>             Project: JBoss Drools
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: drools-brms
>    Affects Versions: 4.0.1
>            Reporter: Geoffrey De Smet
>         Assigned To: Michael Neale
>             Fix For: 4.0.2
>
>
> log4j and slf4j-log4j12 should be test scoped, because only for the tests they are needed, but users can choose their logging implementation themselves.
> In examples you'll probably want to make them runtime scoped.
> slf4j-api is a direct compile time dependency, although currently it's retrieved as a "pseudo transitive dependency" through slf4j-log4j12 which explains why it currently compiles anyway.
> See drools-repository/pom.xml where I 've commented what I propose to change:
>  <dependency>
>           <groupId>org.slf4j</groupId>
>           <artifactId>slf4j-api</artifactId>
>         </dependency>
>         <dependency>
>           <groupId>org.slf4j</groupId>
>           <artifactId>slf4j-log4j12</artifactId>
>           <scope>test</scope>
>         </dependency>
>         <dependency>
>           <groupId>log4j</groupId>
>           <artifactId>log4j</artifactId>
>           <scope>test</scope>
>         </dependency>

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira