[jboss-jira] [JBoss JIRA] Created: (JBMESSAGING-1118) Sucker connection created back to itself doesn't need to be created

[Jay Howell (JIRA)]

Sucker connection created back to itself doesn't need to be created
-------------------------------------------------------------------

                 Key: JBMESSAGING-1118
                 URL: http://jira.jboss.com/jira/browse/JBMESSAGING-1118
             Project: JBoss Messaging
          Issue Type: Bug
          Components: Messaging Core
    Affects Versions: 1.4.0.GA
            Reporter: Jay Howell
         Assigned To: Tim Fox
            Priority: Minor


The following code in ClusteredConnecitonManager creates a connection back to itself and is never used in a non-clustered environment.  So if you have a non-clustered environment, and you are running only one server, if you look at the connections in the peer mbean, you can see the connection client for the sucker.

while (iter.hasNext())
		{
			Map.Entry entry = (Map.Entry)iter.next();
			
			Integer nid = (Integer)entry.getKey();
			
			ClientConnectionFactoryDelegate delegate = (ClientConnectionFactoryDelegate)entry.getValue();
			
			if (connections.get(nid) == null)
			{
				try
				{
   				ConnectionInfo info = new ConnectionInfo(new JBossConnectionFactory(delegate), suckerUser, suckerPassword);
   				
   				log.trace(this + " created connection info " + info);
   				
   				connections.put(nid, info);
   				
   				info.start();
   						         							         			
				}
				catch (Exception e)
				{
					log.error("Failed to start connection info ", e);
				}
			}

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira