[jboss-jira] [JBoss JIRA] Commented: (JBREM-675) Problems with Servlet invoker

[Ron Sigal (JIRA)]

    [ http://jira.jboss.com/jira/browse/JBREM-675?page=comments#action_12385210 ] 
            
Ron Sigal commented on JBREM-675:
---------------------------------

There seem to be three changes in the attached ServletServerInvoker:

1. The MBean Object Name is no longer hard coded.
2. Leasing information is added to responses.
3. Response code 200 is used instead of 204 to avoid a null response.

ServletServerInvoker has been updated as follows:

1. The ServletServerInvoker.getMBeanObjectName() method is deleted, so that org.jboss.remoting.ServerInvoker.getMBeanObjectName() is called instead.  The latter adds values for "port", "host", and all parameters that appear in the InvokerLocator. 

2. Leasing is handled by ServerInvoker and doesn't need to be handled by ServletServerInvoker.

3. The response code issue has been fixed along the lines of the treatment in org.jboss.remoting.transport.coyote.CoyoteInvoker.  That is, if the request did not come from org.jboss.remoting.transport.http.HTTPClientInvoker or the request method was PUT, then 204 is used for a null response.  Otherwise, 200 is used.

> Problems with Servlet invoker
> -----------------------------
>
>                 Key: JBREM-675
>                 URL: http://jira.jboss.com/jira/browse/JBREM-675
>             Project: JBoss Remoting
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: transport
>    Affects Versions: 1.4.6.GA, 2.0.0.GA (Boon)
>            Reporter: Tom  Elrod
>         Assigned To: Ron Sigal
>             Fix For: 2.4.0.Beta1 (Pinto)
>
>         Attachments: ServletServerInvoker.java
>
>
> Several problems with servlet invoker:
> 1) There can't be two servlet invokers (it's necessary, for example, if you want to use them for JBoss Messagning and for EJBs - they require separate connectors) because ObjectName is hard-coded in ServletServerInvoker.java
> 2) Null returns from invokers are sent to client as empty 204 responses and custom marshallers have no change to process return value. This breaks JBoss Messaging which expects that EVERY message contains at least two bytes (version tag and format tag).

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.jboss.com/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira