[jboss-jira] [JBoss JIRA] Closed: (JBAS-6725) quotes around JAVA_OPTS in run.bat

[Mladen Turk (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBAS-6725?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mladen Turk closed JBAS-6725.
-----------------------------

    Resolution: Won't Fix


Because the quotation is needed to allow multiple JAVA_OPTS directives that contain
spaces or braces. Eg. (embedding WoW64 paths like 'Program Files (x86)') the solution
is to use the escape character (^) in front of the special characters
ampersand (&), pipe (|) or redirection characters (<>)

See
http://technet.microsoft.com/en-us/library/bb490954.aspx


> quotes around JAVA_OPTS in run.bat
> ----------------------------------
>
>                 Key: JBAS-6725
>                 URL: https://jira.jboss.org/jira/browse/JBAS-6725
>             Project: JBoss Application Server
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>    Affects Versions: JBossAS-5.0.1.GA, JBossAS-5.1.0.Beta1
>         Environment: Windows XP and JDK 6
>            Reporter: David Croft
>            Assignee: Mladen Turk
>
> In JBoss 4.2.3, I was able to prepend to run.bat a JAVA_OPTS option with a pipe symbol (|) by escaping it using quote marks.
> Example:
> set JAVA_OPTS=-Dhttp.nonProxyHosts="localhost|*.ldms.ibm.com"
> In JBoss 5.0.1.GA and 5.1.0.Beta1, the run.bat script has been modified slightly so that this is no longer possible.  This modification was to wrap JAVA_OPTS with quote marks which will not parse if JAVA_OPTS already has quote marks as in the above example.  There are two places where this occurs.  Here is the first place:
> if "x%JAVA_OPTS%" == "x" (
>   set "JAVA_OPTS=-Dprogram.name=%PROGNAME%"
> ) else (
>   set "JAVA_OPTS=%JAVA_OPTS% -Dprogram.name=%PROGNAME%"
> )
> The first place where it occurs can be fixed by reverting to the version 4.2.3 run.bat code without quote marks:
> set JAVA_OPTS=%JAVA_OPTS% -Dprogram.name=%PROGNAME%
> The second place it occurs is as follows:
> if not errorlevel == 1 (
>   set "JAVA_OPTS=%JAVA_OPTS% -server"
> )
> This second place can be fixed by removing the quote marks:
> if not errorlevel == 1 (
>   set JAVA_OPTS=%JAVA_OPTS% -server
> )

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira