[jboss-jira] [JBoss JIRA] Created: (JGRP-949) Format Version printed rather than showing the short form.

[Galder Zamarreño (JIRA)]

Format Version printed rather than showing the short form.
----------------------------------------------------------

                 Key: JGRP-949
                 URL: https://jira.jboss.org/jira/browse/JGRP-949
             Project: JGroups
          Issue Type: Feature Request
    Affects Versions: 2.4.4
            Reporter: Galder Zamarreño
            Assignee: Bela Ban
            Priority: Minor
             Fix For: 2.4.6


BasicConnectionTable.readPeerAddress:

log.warn(new StringBuffer("packet from ").append(client_addr).append(':').append(client_port).
  append(" has different version (").append(version).append(") from ours (").
  append(Version.version).append("). This may cause problems"));

Should instead look like this:

log.warn(new StringBuffer("packet from ").append(client_addr).append(':').append(client_port).
  append(" has different version (").append(version).append(") from ours (").
  append(Version.print(Version.version)).append("). This may cause problems"));

Note the change from Version.version to Version.print(Version.version).

This is to enable easier debugging. The short version for 2.4.4 is 4356 which looks quite confusing at first 
glance. A node saying that their version is 4356? Which one is it? The change would make it show 2.4.4 
which is provides easier identification.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira