[jboss-jira] [JBoss JIRA] Updated: (JBMESSAGING-1591) ServerInvokerCallbackHandler is not cleaned up properly after a client faliure.

[Tim Fox (JIRA)]

     [ https://jira.jboss.org/jira/browse/JBMESSAGING-1591?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Fox updated JBMESSAGING-1591:
---------------------------------

    Issue Type: Task  (was: Bug)


Changed to task from bug, since this is a bug in JBR, not JBM.

> ServerInvokerCallbackHandler is not cleaned up properly after a client faliure.
> -------------------------------------------------------------------------------
>
>                 Key: JBMESSAGING-1591
>                 URL: https://jira.jboss.org/jira/browse/JBMESSAGING-1591
>             Project: JBoss Messaging
>          Issue Type: Task
>    Affects Versions: 1.4.0.SP3.CP07, 1.4.2.GA.SP1, 1.4.3.GA
>            Reporter: Howard Gao
>            Assignee: Howard Gao
>             Fix For: 1.4.0.SP3.CP08, 1.4.4.GA
>
>
> When a JMS client crashed, the server doesn't clean up the ServerInvokerCallbackHandler, resulting in leak.
> [quote from Ron, remoting team]
> Instances of org.jboss.remoting.callback.ServerInvokerCallbackHandler are leaking when the client doesn't close a JMS connection.  When the Remoting Lease times out, JBossMessaging is notified, but not enough cleaning up is getting done.  It looks like a couple of maps in Remoting plus a map in JMSServerInvocationHandler are holding references to instances of ServerInvokerCallbackHandler.  I've created a ServerInvokerCallbackHandler.shutdown() method, and I think the only change necessary in JBossMessaging is for org.jboss.jms.server.endpoint.ServerConnectionEndpoint.closeCallbackClient() to call
>  callbackHandler.shutdown();
> instead of
> callbackHandler.getCallbackClient().disconnect();

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://jira.jboss.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira