[jboss-jira] [JBoss JIRA] Updated: (JBMESSAGING-1870) ClientSocketWrapper constructors have a redundant call to createStreams()

[Yong Hao Gao (JIRA)]

     [ https://issues.jboss.org/browse/JBMESSAGING-1870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Yong Hao Gao updated JBMESSAGING-1870:
--------------------------------------

    Fix Version/s: 1.4.8.SP4
                       (was: 1.4.8.SP3)


> ClientSocketWrapper constructors have a redundant call to createStreams()
> -------------------------------------------------------------------------
>
>                 Key: JBMESSAGING-1870
>                 URL: https://issues.jboss.org/browse/JBMESSAGING-1870
>             Project: JBoss Messaging
>          Issue Type: Bug
>    Affects Versions: 1.4.0.SP3.CP12, 1.4.8.GA
>            Reporter: Ron Sigal
>            Assignee: Yong Hao Gao
>            Priority: Minor
>             Fix For: 1.4.0.SP3.CP15, 1.4.8.SP4
>
>
> org.jboss.jms.client.remoting.ClientSocketWrapper is derived from org.jboss.remoting.transport.socket.ClientSocketWrapper.  The constructors of the former look like
>    public ClientSocketWrapper(Socket socket) throws IOException
>    {
>       super(socket);
>       createStreams(socket, null);
>    }
>    public ClientSocketWrapper(Socket socket, Map metadata, Integer timeout) throws Exception
>    {
>       super(socket, metadata, timeout);
>       createStreams(socket, metadata);
>    }
> and the constructors of the latter look like
>    public ClientSocketWrapper(Socket socket) throws IOException
>    {
>       super(socket);
>       createStreams(socket, null);
>    }
>    public ClientSocketWrapper(Socket socket, Map metadata, Integer timeout) throws Exception
>    {
>       super(socket, timeout);
>       createStreams(socket, metadata);
>    }
> The calls to createStreams() in the JBossMessaging versions of ClientSocketWrapper is redundant.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira