[jboss-jira] [JBoss JIRA] Issue Comment Edited: (AS7-1786) Fix OSGi description providers for the improved validation in jboss-as-subsystem-test

[Kabir Khan (JIRA)]

    [ https://issues.jboss.org/browse/AS7-1786?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12630032#comment-12630032 ] 

Kabir Khan edited comment on AS7-1786 at 9/22/11 3:45 PM:
----------------------------------------------------------

No work has been done on it, you will see errors once you remove the getModelValidationConfiguration() method of the AdditionalInitialization set up in OSGiSubsystemTestCase.createAdditionalInitialization(). Once complete the test should not include that method.

{code}
    protected AdditionalInitialization createAdditionalInitialization() {
        return new AdditionalInitialization(){
            @Override
            protected OperationContext.Type getType() {
                return OperationContext.Type.MANAGEMENT;
            }

            //Delete this :-)
            @Override
            protected ValidationConfiguration getModelValidationConfiguration() {
                //TODO fix validation https://issues.jboss.org/browse/AS7-1786
                return null;
            }
        };
    }
{code}


      was (Author: kabirkhan):
    No work has been done on it, you will see errors once you remove the getModelValidationConfiguration() method of the AdditionalInitialization set up in OSGiSubsystemTestCase.createAdditionalInitialization(). Once complete the test should not include that method.


    protected AdditionalInitialization createAdditionalInitialization() {
        return new AdditionalInitialization(){
            @Override
            protected OperationContext.Type getType() {
                return OperationContext.Type.MANAGEMENT;
            }

            //Delete this :-)
            @Override
            protected ValidationConfiguration getModelValidationConfiguration() {
                //TODO fix validation https://issues.jboss.org/browse/AS7-1786
                return null;
            }
        };
    }

  
> Fix OSGi description providers for the improved validation in jboss-as-subsystem-test
> -------------------------------------------------------------------------------------
>
>                 Key: AS7-1786
>                 URL: https://issues.jboss.org/browse/AS7-1786
>             Project: Application Server 7
>          Issue Type: Feature Request
>          Components: OSGi
>            Reporter: Kabir Khan
>            Assignee: David Bosschaert
>             Fix For: 7.1.0.Beta1
>
>
> I am adding some more validation of the model. This will be committed to upstream in the next few days. To make the security tests pass I had to override AdditionalInitialization.getModelValidationConfiguration() as follows:
> {code}
>             @Override
>             protected ValidationConfiguration getModelValidationConfiguration() {
>                 return null;
>             }
> {code}
> Returning null basically turns off validation of the providers. These are the errors that happen (this might change a bit before I commit the final version of the validation stuff):
> {code}
> VALIDATION ERRORS IN MODEL:
> Invalid key 'attributes' found for child type 'configuration' @[("subsystem" => "osgi")]
> No value-type for type=OBJECT {"description" => "The configuration data associated with the PID.","type" => OBJECT,"required" => true,"acces
> s-type" => "read-only","storage" => "configuration"} for attribute 'entries'[
>     ("subsystem" => "osgi"),
>     ("configuration" => "*")
> ]
> No value-type for type=OBJECT {"description" => "The configuration data associated with the PID.","type" => OBJECT,"required" => true} for o
> peration parameter 'add.entries' @[
>     ("subsystem" => "osgi"),
>     ("configuration" => "*")
> ]
> Invalid key 'attributes' found for child type 'property' @[("subsystem" => "osgi")]
> Invalid key 'attributes' found for child type 'module' @[("subsystem" => "osgi")]
> {code}
> The work in progress lives at https://github.com/kabir/jboss-as/tree/subsystem-test-model-fixes

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira